Re: [Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-03 Thread Sergey Fedorov
On 02.06.2015 16:54, Peter Maydell wrote: > On 2 June 2015 at 13:21, Sergey Fedorov wrote: >> According to ARM Cortex-A57 TRM, REVIDR reset value should be zero. So >> let REVIDR reset value be specified by CPU model and fix it for >> Cortex-A57. >> >> Signed-off-by: Sergey Fedorov >> -- > Do you

Re: [Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-03 Thread Sergey Fedorov
On 02.06.2015 16:28, Peter Maydell wrote: > On 2 June 2015 at 14:18, Peter Maydell wrote: >> NB: a bug that's been on my todo list for ages is that the comment >> is incorrect about the wildcard being unnecessary -- this was a >> misreading of the ARM ARM by me when I wrote that code. v8 *does* >>

Re: [Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 13:21, Sergey Fedorov wrote: > According to ARM Cortex-A57 TRM, REVIDR reset value should be zero. So > let REVIDR reset value be specified by CPU model and fix it for > Cortex-A57. > > Signed-off-by: Sergey Fedorov > -- Do you have guest software that actually cares about the

Re: [Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 14:18, Peter Maydell wrote: > NB: a bug that's been on my todo list for ages is that the comment > is incorrect about the wildcard being unnecessary -- this was a > misreading of the ARM ARM by me when I wrote that code. v8 *does* > retain the aliases of the MIDR at any unoccupie

Re: [Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 13:51, Shannon Zhao wrote: > Hi, > > On 2015/6/2 20:21, Sergey Fedorov wrote: >> According to ARM Cortex-A57 TRM, REVIDR reset value should be zero. So >> let REVIDR reset value be specified by CPU model and fix it for >> Cortex-A57. >> > > Also need to fix it for Cortex-A53? Ye

Re: [Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-02 Thread Shannon Zhao
Hi, On 2015/6/2 20:21, Sergey Fedorov wrote: > According to ARM Cortex-A57 TRM, REVIDR reset value should be zero. So > let REVIDR reset value be specified by CPU model and fix it for > Cortex-A57. > Also need to fix it for Cortex-A53? > Signed-off-by: Sergey Fedorov > --- > target-arm/cpu-qo

[Qemu-devel] [PATCH] target-arm: fix REVIDR reset value

2015-06-02 Thread Sergey Fedorov
According to ARM Cortex-A57 TRM, REVIDR reset value should be zero. So let REVIDR reset value be specified by CPU model and fix it for Cortex-A57. Signed-off-by: Sergey Fedorov --- target-arm/cpu-qom.h | 1 + target-arm/cpu64.c | 1 + target-arm/helper.c | 2 +- 3 files changed, 3 insertions(