Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-25 Thread Sergey Fedorov
On 25.09.2015 14:34, Sergey Fedorov wrote: > On 18.09.2015 17:07, Sergey Fedorov wrote: >> On 18.09.2015 16:50, Peter Maydell wrote: >>> On 14 September 2015 at 11:51, Sergey Fedorov wrote: >>> @@ -904,7 +913,16 @@ void arm_debug_excp_handler(CPUState *cs) >>> arm_debug_target

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-25 Thread Sergey Fedorov
On 18.09.2015 17:07, Sergey Fedorov wrote: > On 18.09.2015 16:50, Peter Maydell wrote: >> On 14 September 2015 at 11:51, Sergey Fedorov wrote: >> @@ -904,7 +913,16 @@ void arm_debug_excp_handler(CPUState *cs) >> arm_debug_target_el(env)); >> } >> } else { >> -

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 19:36, Peter Maydell wrote: > On 18 September 2015 at 17:33, Sergey Fedorov wrote: >> On 18.09.2015 17:14, Peter Maydell wrote: >>> On 18 September 2015 at 15:07, Sergey Fedorov wrote: On 18.09.2015 16:50, Peter Maydell wrote: > On 14 September 2015 at 11:51, Sergey Fedorov

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 17:14, Peter Maydell wrote: > On 18 September 2015 at 15:07, Sergey Fedorov wrote: >> On 18.09.2015 16:50, Peter Maydell wrote: >>> On 14 September 2015 at 11:51, Sergey Fedorov wrote: --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -11000,11 +110

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:33, Sergey Fedorov wrote: > On 18.09.2015 17:14, Peter Maydell wrote: >> On 18 September 2015 at 15:07, Sergey Fedorov wrote: >>> On 18.09.2015 16:50, Peter Maydell wrote: On 14 September 2015 at 11:51, Sergey Fedorov wrote: > --- a/target-arm/translate-a64.c

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Peter Maydell
On 14 September 2015 at 11:51, Sergey Fedorov wrote: > A QEMU breakpoint match is not definitely an architectural breakpoint > match. If an exception is generated unconditionally during translation, > it is hardly possible to ignore it in the debug exceptoin hanlder. "exception". > > Generate a

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Sergey Fedorov
On 18.09.2015 16:50, Peter Maydell wrote: > On 14 September 2015 at 11:51, Sergey Fedorov wrote: >> A QEMU breakpoint match is not definitely an architectural breakpoint >> match. If an exception is generated unconditionally during translation, >> it is hardly possible to ignore it in the debug ex

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 15:07, Sergey Fedorov wrote: > On 18.09.2015 16:50, Peter Maydell wrote: >> On 14 September 2015 at 11:51, Sergey Fedorov wrote: >>> --- a/target-arm/translate-a64.c >>> +++ b/target-arm/translate-a64.c >>> @@ -11000,11 +11000,13 @@ void gen_intermediate_code_internal_a64

[Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

2015-09-14 Thread Sergey Fedorov
A QEMU breakpoint match is not definitely an architectural breakpoint match. If an exception is generated unconditionally during translation, it is hardly possible to ignore it in the debug exceptoin hanlder. Generate a call to helper to check CPU breakpoints and raise an exception only if any bre