Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-06-06 Thread riku voipio
On 06/03/2011 11:47 PM, Aurelien Jarno wrote: On Mon, May 02, 2011 at 05:01:24PM +0100, Peter Maydell wrote: On 20 April 2011 15:52, Peter Maydell wrote: Move VLD/VST multiple into helper functions, as some cases can generate more TCG ops than the maximum per-instruction limit and certainly mo

Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-06-04 Thread Peter Maydell
On 3 June 2011 21:47, Aurelien Jarno wrote: > Does this patch fixes a real issue (ie most probably a crash), or it is > just to make the arm target compliant with the README? I haven't actually generated a test case which would make qemu abort, but it shouldn't be hard to do so. > Two remarks th

Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-06-03 Thread Aurelien Jarno
On Mon, May 02, 2011 at 05:01:24PM +0100, Peter Maydell wrote: > On 20 April 2011 15:52, Peter Maydell wrote: > > Move VLD/VST multiple into helper functions, as some cases can > > generate more TCG ops than the maximum per-instruction limit > > and certainly more than the recommended 20. > > I'v

Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-05-02 Thread Peter Maydell
On 20 April 2011 15:52, Peter Maydell wrote: > Move VLD/VST multiple into helper functions, as some cases can > generate more TCG ops than the maximum per-instruction limit > and certainly more than the recommended 20. I've had a review comment in private email that this patch slows down ffmpeg b

Re: [Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-04-28 Thread Peter Maydell
Ping? The two UNDEF patches have both been applied, so this patch applies cleanly to master now. -- PMM On 20 April 2011 15:52, Peter Maydell wrote: > Move VLD/VST multiple into helper functions, as some cases can > generate more TCG ops than the maximum per-instruction limit > and certainly mor

[Qemu-devel] [PATCH] target-arm: Move VLD/VST multiple into helper functions

2011-04-20 Thread Peter Maydell
Move VLD/VST multiple into helper functions, as some cases can generate more TCG ops than the maximum per-instruction limit and certainly more than the recommended 20. Signed-off-by: Peter Maydell --- This patch is inspired by one from the meego tree: http://git.linaro.org/gitweb?p=qemu/qemu-li