Re: [Qemu-devel] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macro

2018-10-08 Thread Cornelia Huck
On Fri, 5 Oct 2018 17:00:01 +0200 Thomas Huth wrote: > Debug macros that are disabled by default should be avoided (since the > code bit-rots quite easily). Thus turn these debug prints into proper > qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements > in do_[ext|io|mchk]

Re: [Qemu-devel] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macro

2018-10-08 Thread David Hildenbrand
On 05/10/2018 17:00, Thomas Huth wrote: > Debug macros that are disabled by default should be avoided (since the > code bit-rots quite easily). Thus turn these debug prints into proper > qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements > in do_[ext|io|mchk]_interrupt can e

[Qemu-devel] [PATCH] target/s390x/excp_helper: Remove DPRINTF() macro

2018-10-05 Thread Thomas Huth
Debug macros that are disabled by default should be avoided (since the code bit-rots quite easily). Thus turn these debug prints into proper qemu_log_mask(CPU_LOG_xxx, ...) statements instead. The DPRINTF statements in do_[ext|io|mchk]_interrupt can even be removed completely since we can log the i