Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Peter Maydell
On 4 September 2017 at 17:38, Laurent Vivier wrote: > Le 04/09/2017 à 18:38, Kamil Rytarowski a écrit : >> I will push my patch as is and later it can be refactored by a >> maintainer. Is this fine? >> >> https://github.com/NetBSD/pkgsrc-wip/blob/master/qemu-git/patches/patch-target_m68k_fpu__help

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Laurent Vivier
Le 04/09/2017 à 18:38, Kamil Rytarowski a écrit : > On 04.09.2017 18:17, Peter Maydell wrote: >> On 4 September 2017 at 16:53, Laurent Vivier wrote: >>> Le 04/09/2017 à 17:02, Peter Maydell a écrit : On 4 September 2017 at 15:09, Laurent Vivier wrote: > You can: > > either replac

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 18:17, Peter Maydell wrote: > On 4 September 2017 at 16:53, Laurent Vivier wrote: >> Le 04/09/2017 à 17:02, Peter Maydell a écrit : >>> On 4 September 2017 at 15:09, Laurent Vivier wrote: You can: either replace the "#define floatx80_pi make_floatx80(...)" by a "const

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Peter Maydell
On 4 September 2017 at 16:53, Laurent Vivier wrote: > Le 04/09/2017 à 17:02, Peter Maydell a écrit : >> On 4 September 2017 at 15:09, Laurent Vivier wrote: >>> You can: >>> >>> either replace the "#define floatx80_pi make_floatx80(...)" by a "const >>> floatx80 floatx80_pi = make_floatx80_init(..

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Laurent Vivier
Le 04/09/2017 à 17:02, Peter Maydell a écrit : > On 4 September 2017 at 15:09, Laurent Vivier wrote: >> You can: >> >> either replace the "#define floatx80_pi make_floatx80(...)" by a "const >> floatx80 floatx80_pi = make_floatx80_init(...)" >> >> or replace all the macros in the m68k/fpu_helper.c

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 17:02, Peter Maydell wrote: > On 4 September 2017 at 15:09, Laurent Vivier wrote: >> You can: >> >> either replace the "#define floatx80_pi make_floatx80(...)" by a "const >> floatx80 floatx80_pi = make_floatx80_init(...)" >> >> or replace all the macros in the m68k/fpu_helper.c arra

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Peter Maydell
On 4 September 2017 at 15:09, Laurent Vivier wrote: > You can: > > either replace the "#define floatx80_pi make_floatx80(...)" by a "const > floatx80 floatx80_pi = make_floatx80_init(...)" > > or replace all the macros in the m68k/fpu_helper.c array by > make_floatx80_init(...) Taking a step back

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 16:41, Philippe Mathieu-Daudé wrote: > On 09/04/2017 11:09 AM, Laurent Vivier wrote: >> Le 04/09/2017 à 15:54, Kamil Rytarowski a écrit : >>> On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote: On 09/03/2017 02:05 PM, Laurent Vivier wrote: > Le 03/09/2017 à 18:31, Kamil Rytaro

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Philippe Mathieu-Daudé
On 09/04/2017 11:09 AM, Laurent Vivier wrote: Le 04/09/2017 à 15:54, Kamil Rytarowski a écrit : On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote: On 09/03/2017 02:05 PM, Laurent Vivier wrote: Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit : GCC 4.7.2 on SunOS reports that the values assigne

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Laurent Vivier
Le 04/09/2017 à 15:54, Kamil Rytarowski a écrit : > On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote: >> On 09/03/2017 02:05 PM, Laurent Vivier wrote: >>> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit : GCC 4.7.2 on SunOS reports that the values assigned to array members are not r

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread Kamil Rytarowski
On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote: > On 09/03/2017 02:05 PM, Laurent Vivier wrote: >> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit : >>> GCC 4.7.2 on SunOS reports that the values assigned to array members >>> are not >>> real constants: >>> >>> target/m68k/fpu_helper.c:32:5: err

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-04 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Message-id: 20170903163130.14288-1-...@gmx.com Subject: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will be

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-03 Thread Philippe Mathieu-Daudé
On 09/03/2017 02:05 PM, Laurent Vivier wrote: Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit : GCC 4.7.2 on SunOS reports that the values assigned to array members are not real constants: target/m68k/fpu_helper.c:32:5: error: initializer element is not constant target/m68k/fpu_helper.c:32:5: e

Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-03 Thread Laurent Vivier
Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit : > GCC 4.7.2 on SunOS reports that the values assigned to array members are not > real constants: > > target/m68k/fpu_helper.c:32:5: error: initializer element is not constant > target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom

[Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch

2017-09-03 Thread Kamil Rytarowski
GCC 4.7.2 on SunOS reports that the values assigned to array members are not real constants: target/m68k/fpu_helper.c:32:5: error: initializer element is not constant target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]') rules.mak:66: recipe for target 'target/m68k/fpu_helpe