Re: [Qemu-devel] [PATCH] target/arm: crash on conditional instr in it block

2018-08-15 Thread Roman Kapl
Hi and thanks for review, On 08/14/2018 08:12 PM, Peter Maydell wrote: On 14 August 2018 at 17:54, Roman Kapl wrote: If an instruction is conditional (like CBZ) and it is executed conditionally (using the ITx instruction), a jump to undefined label is generated. Fix the 'skip on condtion' cod

Re: [Qemu-devel] [PATCH] target/arm: crash on conditional instr in it block

2018-08-15 Thread Peter Maydell
On 15 August 2018 at 09:30, Roman Kapl wrote: > Hi and thanks for review, > > On 08/14/2018 08:12 PM, Peter Maydell wrote: >> >> On 14 August 2018 at 17:54, Roman Kapl wrote: >>> >>> If an instruction is conditional (like CBZ) and it is executed >>> conditionally >>> (using the ITx instruction),

[Qemu-devel] [PATCH] target/arm: crash on conditional instr in it block

2018-08-14 Thread Roman Kapl
If an instruction is conditional (like CBZ) and it is executed conditionally (using the ITx instruction), a jump to undefined label is generated. Fix the 'skip on condtion' code to create a new label only if it does not already exist. Previously multiple labels were created, but only the last one

Re: [Qemu-devel] [PATCH] target/arm: crash on conditional instr in it block

2018-08-14 Thread Peter Maydell
On 14 August 2018 at 17:54, Roman Kapl wrote: > If an instruction is conditional (like CBZ) and it is executed conditionally > (using the ITx instruction), a jump to undefined label is generated. > > Fix the 'skip on condtion' code to create a new label only if it does not > already exist. Previou

[Qemu-devel] [PATCH] target/arm: crash on conditional instr in it block

2018-08-14 Thread Roman Kapl
If an instruction is conditional (like CBZ) and it is executed conditionally (using the ITx instruction), a jump to undefined label is generated. Fix the 'skip on condtion' code to create a new label only if it does not already exist. Previously multiple labels were created, but only the last one