Re: [Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-12 Thread Gerd Hoffmann
Hi, There is no ledstate in a PS/2 keyboard (or I'm reading too much into the implementation in qemu). There is. It isn't explicitly stored into the state struct though because the ps/2 keyboard itself doesn't use it, it just calls kbd_put_ledstate() to inform others about it. cheers,

Re: [Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-11 Thread Alon Levy
On Tue, Oct 11, 2011 at 01:23:00PM -0500, Anthony Liguori wrote: > On 10/11/2011 11:28 AM, Alon Levy wrote: > >The caps/scroll/num lock state is not tracked by the ps2 device, but by > >spice-input QemuSpiceKbd->ledstate. To fix losing it across migration, > >and then having the server send caps/sc

Re: [Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-11 Thread Anthony Liguori
On 10/11/2011 11:28 AM, Alon Levy wrote: The caps/scroll/num lock state is not tracked by the ps2 device, but by spice-input QemuSpiceKbd->ledstate. To fix losing it across migration, and then having the server send caps/scroll/nums keys when the client sends a SPICE_MSGC_INPUTS_KEY_MODIFIERS, mi

[Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-11 Thread Alon Levy
The caps/scroll/num lock state is not tracked by the ps2 device, but by spice-input QemuSpiceKbd->ledstate. To fix losing it across migration, and then having the server send caps/scroll/nums keys when the client sends a SPICE_MSGC_INPUTS_KEY_MODIFIERS, migrate it. RHBZ# 729294 Signed-off-by: Alo

Re: [Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-11 Thread Alon Levy
On Tue, Oct 11, 2011 at 06:42:48PM +0200, Alon Levy wrote: > The caps/scroll/num lock state is not tracked by the ps2 device, but by > spice-input QemuSpiceKbd->ledstate. To fix losing it across migration, > and then having the server send caps/scroll/nums keys when the client > sends a SPICE_MSGC_

[Qemu-devel] [PATCH] spice-input: migrate ledstate

2011-10-11 Thread Alon Levy
The caps/scroll/num lock state is not tracked by the ps2 device, but by spice-input QemuSpiceKbd->ledstate. To fix losing it across migration, and then having the server send caps/scroll/nums keys when the client sends a SPICE_MSGC_INPUTS_KEY_MODIFIERS, migrate it. RHBZ# 729294 Signed-off-by: Alo