Re: [Qemu-devel] [PATCH] spice-char: fix segfault in char_spice_finalize

2017-02-20 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2017 at 7:38 AM Li Qiang wrote: > In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will > call 'char_spice_finalize'. But as the SpiceChardev is not inserted > in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault. > Add a detect to avoid it. > > Signe

[Qemu-devel] [PATCH] spice-char: fix segfault in char_spice_finalize

2017-02-20 Thread Li Qiang
In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will call 'char_spice_finalize'. But as the SpiceChardev is not inserted in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault. Add a detect to avoid it. Signed-off-by: Li Qiang --- spice-qemu-char.c | 5 - 1 file chang