Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2013-01-03 Thread Stefan Hajnoczi
On Thu, Jan 3, 2013 at 9:20 AM, Gerd Hoffmann wrote: > On 01/02/13 16:56, Stefan Hajnoczi wrote: >> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: >>> The spice_server pointer is a global variable and >>> vm_change_state_handler() therefore does not use its opaque parameter. >>>

Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2013-01-03 Thread Gerd Hoffmann
On 01/02/13 16:56, Stefan Hajnoczi wrote: > On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: >> The spice_server pointer is a global variable and >> vm_change_state_handler() therefore does not use its opaque parameter. >> >> The vm change state handler is added with a pointer to th

Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2013-01-02 Thread Stefan Hajnoczi
On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: > The spice_server pointer is a global variable and > vm_change_state_handler() therefore does not use its opaque parameter. > > The vm change state handler is added with a pointer to the spice_server > pointer. This is useless and

Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2012-12-19 Thread Uri Lublin
On 12/19/2012 03:07 PM, Stefan Hajnoczi wrote: The spice_server pointer is a global variable and ... is a static variable in ui/spice-core.c and vm_change_state_handler() therefore does not use its opaque parameter. The vm change state handler is added with a pointer to the spice_server poin

[Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2012-12-19 Thread Stefan Hajnoczi
The spice_server pointer is a global variable and vm_change_state_handler() therefore does not use its opaque parameter. The vm change state handler is added with a pointer to the spice_server pointer. This is useless and we probably would not want 2 levels of pointers. Signed-off-by: Stefan Haj