Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 22:31:26 +1000 David Gibson wrote: > On Thu, Sep 14, 2017 at 09:03:15AM +0200, Greg Kurz wrote: > > Creating several PHBs without index property confuses the DRC code > > and causes issues: > > - only the first index-less PHB is functional, the other ones will > > silently i

Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 09:03:15AM +0200, Greg Kurz wrote: > Creating several PHBs without index property confuses the DRC code > and causes issues: > - only the first index-less PHB is functional, the other ones will > silently ignore hotplugging of PCI devices > - QEMU will even terminate if th

Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory Message-id: 150537259490.3298.1180094221641142666.stgit@bahia Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
Creating several PHBs without index property confuses the DRC code and causes issues: - only the first index-less PHB is functional, the other ones will silently ignore hotplugging of PCI devices - QEMU will even terminate if these PHBs have cold-plugged devices qemu-system-ppc64: -device virtio