Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-29 Thread Laurent Vivier
On 27/01/2018 10:15, David Gibson wrote: > On Fri, Jan 26, 2018 at 11:25:24PM +0100, Greg Kurz wrote: >> In various place we don't correctly check if the device supports MSI or >> MSI-X. This can cause devices to be advertised with MSI support, even >> if they only support MSI-X (like virtio-pci-*

Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-29 Thread Greg Kurz
On Sat, 27 Jan 2018 20:15:52 +1100 David Gibson wrote: > On Fri, Jan 26, 2018 at 11:25:24PM +0100, Greg Kurz wrote: > > In various place we don't correctly check if the device supports MSI or > > MSI-X. This can cause devices to be advertised with MSI support, even > > if they only support MSI-X

Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-28 Thread Alexey Kardashevskiy
On 27/01/18 09:25, Greg Kurz wrote: > In various place we don't correctly check if the device supports MSI or > MSI-X. This can cause devices to be advertised with MSI support, even > if they only support MSI-X (like virtio-pci-* devices for example): > > ethernet@0 { >

Re: [Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-27 Thread David Gibson
On Fri, Jan 26, 2018 at 11:25:24PM +0100, Greg Kurz wrote: > In various place we don't correctly check if the device supports MSI or > MSI-X. This can cause devices to be advertised with MSI support, even > if they only support MSI-X (like virtio-pci-* devices for example): > > eth

[Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-26 Thread Greg Kurz
In various place we don't correctly check if the device supports MSI or MSI-X. This can cause devices to be advertised with MSI support, even if they only support MSI-X (like virtio-pci-* devices for example): ethernet@0 { ibm,req#msi = <0x1>; <--- wrong!