Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread David Gibson
On Thu, Jul 13, 2017 at 08:54:58AM +0530, Bharata B Rao wrote: > On Wed, Jul 12, 2017 at 01:11:30PM +0200, Greg Kurz wrote: > > On Wed, 12 Jul 2017 15:52:37 +0530 > > Bharata B Rao wrote: > > > > > On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > > > > Since commit 5c1da81215c7 ("spap

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread Bharata B Rao
On Wed, Jul 12, 2017 at 01:11:30PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 15:52:37 +0530 > Bharata B Rao wrote: > > > On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > > > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > > > hotplug and coldplug paths"

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread David Gibson
On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. > This causes a memory leak for pseries-2.6 and older machine types, that > don't suppor

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread Greg Kurz
On Wed, 12 Jul 2017 15:52:37 +0530 Bharata B Rao wrote: > On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > > hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. > > This causes a memory

Re: [Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread Bharata B Rao
On Wed, Jul 12, 2017 at 11:48:39AM +0200, Greg Kurz wrote: > Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between > hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. > This causes a memory leak for pseries-2.6 and older machine types, that > don't suppor

[Qemu-devel] [PATCH] spapr: fix potential memory leak in spapr_core_plug()

2017-07-12 Thread Greg Kurz
Since commit 5c1da81215c7 ("spapr: Remove unnecessary differences between hotplug and coldplug paths"), the CPU DT for the DRC is always allocated. This causes a memory leak for pseries-2.6 and older machine types, that don't support CPU hotplug and don't allocate DRCs for CPUs. Reported-by: Bhara