Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-11 Thread David Gibson
On Thu, Jan 11, 2018 at 01:24:30PM +0100, Greg Kurz wrote: > On Fri, 5 Jan 2018 14:07:29 +1100 > David Gibson wrote: > > > On Thu, Jan 04, 2018 at 06:47:18PM +0100, Greg Kurz wrote: > > > On Thu, 4 Jan 2018 15:24:05 +1100 > > > David Gibson wrote: > > > > > > > Currently the pseries machine

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-11 Thread Greg Kurz
On Fri, 5 Jan 2018 14:07:29 +1100 David Gibson wrote: > On Thu, Jan 04, 2018 at 06:47:18PM +0100, Greg Kurz wrote: > > On Thu, 4 Jan 2018 15:24:05 +1100 > > David Gibson wrote: > > > > > Currently the pseries machine sets the compatibility mode for the > > > guest's cpus in two places: 1) at

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread David Gibson
On Thu, Jan 04, 2018 at 03:11:03PM -0600, Michael Roth wrote: > Quoting Greg Kurz (2018-01-04 11:47:18) > > On Thu, 4 Jan 2018 15:24:05 +1100 > > David Gibson wrote: > > > > > Currently the pseries machine sets the compatibility mode for the > > > guest's cpus in two places: 1) at machine reset

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread David Gibson
On Thu, Jan 04, 2018 at 06:47:18PM +0100, Greg Kurz wrote: > On Thu, 4 Jan 2018 15:24:05 +1100 > David Gibson wrote: > > > Currently the pseries machine sets the compatibility mode for the > > guest's cpus in two places: 1) at machine reset and 2) after CAS > > negotiation. > > > > This means t

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread Michael Roth
Quoting Greg Kurz (2018-01-04 11:47:18) > On Thu, 4 Jan 2018 15:24:05 +1100 > David Gibson wrote: > > > Currently the pseries machine sets the compatibility mode for the > > guest's cpus in two places: 1) at machine reset and 2) after CAS > > negotiation. > > > > This means that if we set or ne

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-04 Thread Greg Kurz
On Thu, 4 Jan 2018 15:24:05 +1100 David Gibson wrote: > Currently the pseries machine sets the compatibility mode for the > guest's cpus in two places: 1) at machine reset and 2) after CAS > negotiation. > > This means that if we set or negotiate a compatiblity mode, then > hotplug a cpu, the h

Re: [Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-03 Thread Alexey Kardashevskiy
On 04/01/18 15:24, David Gibson wrote: > Currently the pseries machine sets the compatibility mode for the > guest's cpus in two places: 1) at machine reset and 2) after CAS > negotiation. > > This means that if we set or negotiate a compatiblity mode, then > hotplug a cpu, the hotplugged cpu does

[Qemu-devel] [PATCH] spapr: Correct compatibility mode setting for hotplugged CPUs

2018-01-03 Thread David Gibson
Currently the pseries machine sets the compatibility mode for the guest's cpus in two places: 1) at machine reset and 2) after CAS negotiation. This means that if we set or negotiate a compatiblity mode, then hotplug a cpu, the hotplugged cpu doesn't get the right mode set and will incorrectly hav