Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-06-01 Thread Daniel P . Berrangé
On Tue, May 29, 2018 at 10:52:40AM +0800, linzhecheng wrote: > Signed-off-by: linzhecheng > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index 159e69c3b1..17519ec589 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -134,8 +134,8 @@ static int tcp_chr_write

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-30 Thread Gonglei (Arei)
ct: Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals > EAGAIN > > On 05/29/2018 04:33 AM, linzhecheng wrote: > > I think this patch doesn't fix my issue. For more details, please see > > Gonglei's > reply. > > https://lists.gnu.o

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread Peter Xu
On Tue, May 29, 2018 at 10:52:40AM +0800, linzhecheng wrote: > Signed-off-by: linzhecheng > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index 159e69c3b1..17519ec589 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -134,8 +134,8 @@ static int tcp_chr_write

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread Eric Blake
On 05/29/2018 04:33 AM, linzhecheng wrote: I think this patch doesn't fix my issue. For more details, please see Gonglei's reply. https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg06296.html Your mailer is not honoring threading (it failed to include 'In-Reply-To:' and 'References:' he

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread linzhecheng
ng > 抄送: QEMU ; Paolo Bonzini > ; wangxin (U) > 主题: Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals > EAGAIN > > Hi > > On Tue, May 29, 2018 at 4:52 AM, linzhecheng > wrote: > > Signed-off-by: linzhecheng > > > > diff --

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread Marc-André Lureau
Hi On Tue, May 29, 2018 at 4:52 AM, linzhecheng wrote: > Signed-off-by: linzhecheng > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index 159e69c3b1..17519ec589 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -134,8 +134,8 @@ static int tcp_chr_write(Char

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread linzhecheng
CC'ing Daniel P. Berrangé , Peter Xu, Marc-André Lureau, Eric Blake, Gonglei > -邮件原件- > 发件人: linzhecheng > 发送时间: 2018年5月29日 10:53 > 收件人: qemu-devel@nongnu.org > 抄送: pbonz...@redhat.com; wangxin (U) ; > linzhecheng > 主题: [PATCH] socket: dont't free msgfds if error equals EAGAIN > > Signed

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread Gonglei (Arei)
Hi all, The issue is easy to reproduce when we confiugred multi-queue function for vhost-user nics. The main backtrace is as follows: vhost_user_write ==> 0) sets s->write_msgfds_num to 8 qemu_chr_fe_write_all qemu_chr_fe_write_buffer ==> 4) rewrite because (ret <0 &

[Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-28 Thread linzhecheng
Signed-off-by: linzhecheng diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 159e69c3b1..17519ec589 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -134,8 +134,8 @@ static int tcp_chr_write(Chardev *chr, const uint8_t *buf, int len)