Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-20 Thread BALATON Zoltan
On Wed, 19 Sep 2018, Marcus Comstedt wrote: BALATON Zoltan writes: Thanks for testing on big endian host and fixing this bug. Have you also tried KVM? That would be interesting but I think it may have problems currently and maybe only PR KVM would work as it need to emulate PPC440 on server CPU

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread David Gibson
On Wed, Sep 19, 2018 at 09:29:31AM -0700, Peter Maydell wrote: > On 19 September 2018 at 07:46, BALATON Zoltan wrote: > > On Wed, 19 Sep 2018, Marcus Comstedt wrote: > >> > >> The value from twoD_foreground (which is in host endian format) must > >> be converted to the endianness of the framebuffe

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread David Gibson
On Wed, Sep 19, 2018 at 06:23:14PM +0200, Marcus Comstedt wrote: > > Hi, > > BALATON Zoltan writes: > > > Thanks for testing on big endian host and fixing this bug. Have you > > also tried KVM? That would be interesting but I think it may have > > problems currently and maybe only PR KVM would

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread Marcus Comstedt
Hi, BALATON Zoltan writes: > Thanks for testing on big endian host and fixing this bug. Have you > also tried KVM? That would be interesting but I think it may have > problems currently and maybe only PR KVM would work as it need to > emulate PPC440 on server CPU but I don't know much about KV

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread Peter Maydell
On 19 September 2018 at 07:46, BALATON Zoltan wrote: > On Wed, 19 Sep 2018, Marcus Comstedt wrote: >> >> The value from twoD_foreground (which is in host endian format) must >> be converted to the endianness of the framebuffer (currently always >> little endian) before it can be used to perform th

Re: [Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread BALATON Zoltan
On Wed, 19 Sep 2018, Marcus Comstedt wrote: The value from twoD_foreground (which is in host endian format) must be converted to the endianness of the framebuffer (currently always little endian) before it can be used to perform the fill operation. Signed-off-by: Marcus Comstedt Reviewed-by:

[Qemu-devel] [PATCH] sm501: Adjust endianness of pixel value in rectangle fill

2018-09-19 Thread Marcus Comstedt
The value from twoD_foreground (which is in host endian format) must be converted to the endianness of the framebuffer (currently always little endian) before it can be used to perform the fill operation. Signed-off-by: Marcus Comstedt --- Hi. I noticed when running AmigaOS 4.1 as a guest that