Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-28 Thread Philippe Mathieu-Daudé
On 1/28/19 12:25 PM, Peter Maydell wrote: > On Mon, 28 Jan 2019 at 11:22, Philippe Mathieu-Daudé > wrote: >> On 1/27/19 12:37 PM, Marc-André Lureau wrote: >>> Did you try using G_STATIC_ASSERT* instead? >> [...] >> >> Is there a same plan for QEMU codebase? > > Our version uses _Static_assert wh

Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-28 Thread Peter Maydell
On Mon, 28 Jan 2019 at 11:22, Philippe Mathieu-Daudé wrote: > On 1/27/19 12:37 PM, Marc-André Lureau wrote: > > Did you try using G_STATIC_ASSERT* instead? > [...] > > Is there a same plan for QEMU codebase? Our version uses _Static_assert where possible, which I think will give better error mess

Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-28 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 1/27/19 12:37 PM, Marc-André Lureau wrote: > Hi > > On Sun, Jan 27, 2019 at 5:55 AM Samuel Thibault > wrote: >> >> (Which I'll fold as appropriate within Marc-André's patch series) > > Did you try using G_STATIC_ASSERT* instead? [...] Is there a same plan for QEMU codebase?

Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-27 Thread Samuel Thibault
Marc-André Lureau, le dim. 27 janv. 2019 15:37:38 +0400, a ecrit: > On Sun, Jan 27, 2019 at 5:55 AM Samuel Thibault > wrote: > > > > (Which I'll fold as appropriate within Marc-André's patch series) > > Did you try using G_STATIC_ASSERT* instead? Ah, right, that can be used instead, sent refine

Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-27 Thread Marc-André Lureau
Hi On Sun, Jan 27, 2019 at 5:55 AM Samuel Thibault wrote: > > (Which I'll fold as appropriate within Marc-André's patch series) Did you try using G_STATIC_ASSERT* instead? looks good otherwise > > Samuel Thibault, le dim. 27 janv. 2019 02:51:13 +0100, a ecrit: > > Signed-off-by: Samuel Thibaul

Re: [Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-26 Thread Samuel Thibault
(Which I'll fold as appropriate within Marc-André's patch series) Samuel Thibault, le dim. 27 janv. 2019 02:51:13 +0100, a ecrit: > Signed-off-by: Samuel Thibault > --- > slirp/ip.h | 6 -- > slirp/ip6.h | 6 -- > slirp/ip6_icmp.h | 12 +++- > slirp/util.h | 25 +

[Qemu-devel] [PATCH] slirp: Replace QEMU_BUILD_BUG_ON with own macro

2019-01-26 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/ip.h | 6 -- slirp/ip6.h | 6 -- slirp/ip6_icmp.h | 12 +++- slirp/util.h | 25 + 4 files changed, 40 insertions(+), 9 deletions(-) diff --git a/slirp/ip.h b/slirp/ip.h index 2baeeb9a3a..77182e61a9