* Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> Dr. David Alan Gilbert, le ven. 12 avril 2019 16:49:42 +0100, a ecrit:
> > * Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> > > Hello,
> > >
> > > Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit:
> > > > 'soread' has th
Dr. David Alan Gilbert, le ven. 12 avril 2019 16:49:42 +0100, a ecrit:
> * Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> > Hello,
> >
> > Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit:
> > > 'soread' has the comment:
> > >
> > > /*
> > > * No need to
* Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> Hello,
>
> Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit:
> > 'soread' has the comment:
> >
> > /*
> > * No need to check if there's enough room to read.
> > * soread wouldn't have been called i
Hello,
Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit:
> 'soread' has the comment:
>
> /*
> * No need to check if there's enough room to read.
> * soread wouldn't have been called if there weren't
> */
> sopreprbuf(so, iov, &n);
>
* Samuel Thibault (samuel.thiba...@gnu.org) wrote:
> Hello,
>
> Dr. David Alan Gilbert (git), le ven. 05 avril 2019 19:46:48 +0100, a ecrit:
> > From: "Dr. David Alan Gilbert"
> >
> > Gcc 9 needs some convincing that sopreprbuf really is going to fill
> > in iov in the call from soreadbuf, even
Hello,
Dr. David Alan Gilbert (git), le ven. 05 avril 2019 19:46:48 +0100, a ecrit:
> From: "Dr. David Alan Gilbert"
>
> Gcc 9 needs some convincing that sopreprbuf really is going to fill
> in iov in the call from soreadbuf, even though the failure case
> shouldn't happen; so swing the check ar
Patchew URL:
https://patchew.org/QEMU/20190405184648.17029-1-dgilb...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190405184648.17029-1-dgilb...@redhat.com
Subject: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix
Type
From: "Dr. David Alan Gilbert"
Gcc 9 needs some convincing that sopreprbuf really is going to fill
in iov in the call from soreadbuf, even though the failure case
shouldn't happen; so swing the check around initialising the fields.
Signed-off-by: Dr. David Alan Gilbert
---
slirp/src/socket.c |
