Re: [Qemu-devel] [PATCH] sh4: fix use_icount with linux-user

2018-08-10 Thread Richard Henderson
On 08/10/2018 03:47 PM, John Paul Adrian Glaubitz wrote: > Fantastic, this fixes it! Can we get this into 3.0.0 before release? Probably not, as -rc4 was supposed to be the last pre-release on Tuesday. But perhaps a revised version can make 3.0.1 (I see problems with this fix). r~

Re: [Qemu-devel] [PATCH] sh4: fix use_icount with linux-user

2018-08-10 Thread Richard Henderson
On 08/10/2018 03:25 PM, Laurent Vivier wrote: > +++ b/target/sh4/translate.c > @@ -253,7 +253,6 @@ static void gen_goto_tb(DisasContext *ctx, int n, > target_ulong dest) > tcg_gen_lookup_and_goto_ptr(); > } > } > -ctx->base.is_jmp = DISAS_NORETURN; > } > Looking

Re: [Qemu-devel] [PATCH] sh4: fix use_icount with linux-user

2018-08-10 Thread John Paul Adrian Glaubitz
On 08/11/2018 12:25 AM, Laurent Vivier wrote: > This patch revert changes from 4834871bc9 that are > not only state renaming. > > This fixes java in a linux-user chroot: > $ java --version > qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion > `use_icount' failed. > qemu: u

[Qemu-devel] [PATCH] sh4: fix use_icount with linux-user

2018-08-10 Thread Laurent Vivier
This patch revert changes from 4834871bc9 that are not only state renaming. This fixes java in a linux-user chroot: $ java --version qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion `use_icount' failed. qemu: uncaught target signal 6 (Aborted) - core dumped Aborted (cor