Re: [Qemu-devel] [PATCH] sh4: Fix potential crash in debug code

2011-08-28 Thread Andreas Färber
Am 20.07.2011 um 20:56 schrieb Stefan Weil: cppcheck reports this error: qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 385 If s were NULL, the printf() statement would crash. Setting braces fixes this bug. Signed-o

Re: [Qemu-devel] [PATCH] sh4: Fix potential crash in debug code

2011-08-27 Thread Stefan Weil
Am 13.08.2011 11:25, schrieb Stefan Weil: Am 20.07.2011 20:56, schrieb Stefan Weil: cppcheck reports this error: qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 385 If s were NULL, the printf() statement would crash

Re: [Qemu-devel] [PATCH] sh4: Fix potential crash in debug code

2011-08-13 Thread Stefan Weil
Am 20.07.2011 20:56, schrieb Stefan Weil: cppcheck reports this error: qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 385 If s were NULL, the printf() statement would crash. Setting braces fixes this bug. Signed-of

[Qemu-devel] [PATCH] sh4: Fix potential crash in debug code

2011-07-20 Thread Stefan Weil
cppcheck reports this error: qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 385 If s were NULL, the printf() statement would crash. Setting braces fixes this bug. Signed-off-by: Stefan Weil --- hw/sh_intc.c |9 +