Re: [Qemu-devel] [PATCH] sd: Don't trace SDRequest crc field

2018-06-28 Thread Peter Maydell
On 26 June 2018 at 19:20, Philippe Mathieu-Daudé wrote: > On 06/26/2018 03:03 PM, Peter Maydell wrote: >> We don't actually implement SD command CRC checking, because >> for almost all of our SD controllers the CRC generation is >> done in hardware, and so modelling CRC generation and checking >>

Re: [Qemu-devel] [PATCH] sd: Don't trace SDRequest crc field

2018-06-26 Thread Philippe Mathieu-Daudé
On 06/26/2018 03:03 PM, Peter Maydell wrote: > We don't actually implement SD command CRC checking, because > for almost all of our SD controllers the CRC generation is > done in hardware, and so modelling CRC generation and checking > would be a bit pointless. (The exception is that milkymist-memc

[Qemu-devel] [PATCH] sd: Don't trace SDRequest crc field

2018-06-26 Thread Peter Maydell
We don't actually implement SD command CRC checking, because for almost all of our SD controllers the CRC generation is done in hardware, and so modelling CRC generation and checking would be a bit pointless. (The exception is that milkymist-memcard makes the guest software compute the CRC.) As a