Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

2015-03-04 Thread Max Reitz
On 2015-03-04 at 09:12, Kevin Wolf wrote: Am 04.03.2015 um 14:58 hat Max Reitz geschrieben: On 2015-03-04 at 07:23, Kevin Wolf wrote: Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: commit "BlockConf: Call backend functions to detect geometry and blocksizes" causes a segmentation fa

Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

2015-03-04 Thread Kevin Wolf
Am 04.03.2015 um 14:58 hat Max Reitz geschrieben: > On 2015-03-04 at 07:23, Kevin Wolf wrote: > >Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: > >>commit "BlockConf: Call backend functions to detect geometry and > >>blocksizes" causes a segmentation fault on the invalid configuration o

Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

2015-03-04 Thread Max Reitz
On 2015-03-04 at 07:23, Kevin Wolf wrote: Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: commit "BlockConf: Call backend functions to detect geometry and blocksizes" causes a segmentation fault on the invalid configuration of a scsi device without a drive. Lets check for conf.blk be

Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

2015-03-04 Thread Kevin Wolf
Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: > commit "BlockConf: Call backend functions to detect geometry and > blocksizes" causes a segmentation fault on the invalid configuration of > a scsi device without a drive. > > Lets check for conf.blk before calling blkconf_blocksizes. Th

[Qemu-devel] [PATCH] scsi-hd: fix property unset case

2015-03-04 Thread Ekaterina Tumanova
commit "BlockConf: Call backend functions to detect geometry and blocksizes" causes a segmentation fault on the invalid configuration of a scsi device without a drive. Lets check for conf.blk before calling blkconf_blocksizes. The error will be handled later on in scsi_realize anyway. Reported-by