Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-28 Thread Tony Krowiak
On 1/14/19 9:16 AM, Cornelia Huck wrote: On Thu, 10 Jan 2019 11:22:48 -0500 Tony Krowiak wrote: Can you extend this patch description a little bit, including what we discussed here? Maybe a short comment that explains why qdev_simple_device_unplug_cb() is appropriate as well (i.e. hits that

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-14 Thread Cornelia Huck
On Thu, 10 Jan 2019 11:22:48 -0500 Tony Krowiak wrote: > >>> Can you extend this patch description a little bit, including what we > >>> discussed here? > >> > >> Maybe a short comment that explains why qdev_simple_device_unplug_cb() > >> is appropriate as well (i.e. hits that closing the mdev'

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-10 Thread Tony Krowiak
On 1/9/19 12:28 PM, David Hildenbrand wrote: On 09.01.19 18:13, Halil Pasic wrote: On Wed, 9 Jan 2019 17:37:49 +0100 David Hildenbrand wrote: On 09.01.19 17:27, Tony Krowiak wrote: On 1/9/19 6:30 AM, Cornelia Huck wrote: On Tue, 8 Jan 2019 23:13:39 +0100 David Hildenbrand wrote: On 08.01

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-09 Thread David Hildenbrand
On 09.01.19 18:13, Halil Pasic wrote: > On Wed, 9 Jan 2019 17:37:49 +0100 > David Hildenbrand wrote: > >> On 09.01.19 17:27, Tony Krowiak wrote: >>> On 1/9/19 6:30 AM, Cornelia Huck wrote: On Tue, 8 Jan 2019 23:13:39 +0100 David Hildenbrand wrote: > On 08.01.19 20:52, Tony Kro

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-09 Thread Halil Pasic
On Wed, 9 Jan 2019 17:37:49 +0100 David Hildenbrand wrote: > On 09.01.19 17:27, Tony Krowiak wrote: > > On 1/9/19 6:30 AM, Cornelia Huck wrote: > >> On Tue, 8 Jan 2019 23:13:39 +0100 > >> David Hildenbrand wrote: > >> > >>> On 08.01.19 20:52, Tony Krowiak wrote: > On 1/8/19 11:09 AM, David

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-09 Thread David Hildenbrand
On 09.01.19 17:27, Tony Krowiak wrote: > On 1/9/19 6:30 AM, Cornelia Huck wrote: >> On Tue, 8 Jan 2019 23:13:39 +0100 >> David Hildenbrand wrote: >> >>> On 08.01.19 20:52, Tony Krowiak wrote: On 1/8/19 11:09 AM, David Hildenbrand wrote: > On 08.01.19 17:01, Tony Krowiak wrote: >> Intr

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-09 Thread Tony Krowiak
On 1/9/19 6:30 AM, Cornelia Huck wrote: On Tue, 8 Jan 2019 23:13:39 +0100 David Hildenbrand wrote: On 08.01.19 20:52, Tony Krowiak wrote: On 1/8/19 11:09 AM, David Hildenbrand wrote: On 08.01.19 17:01, Tony Krowiak wrote: Introduces hot plug/unplug support for the vfio-ap device. Note that

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-09 Thread Cornelia Huck
On Tue, 8 Jan 2019 23:13:39 +0100 David Hildenbrand wrote: > On 08.01.19 20:52, Tony Krowiak wrote: > > On 1/8/19 11:09 AM, David Hildenbrand wrote: > >> On 08.01.19 17:01, Tony Krowiak wrote: > >>> Introduces hot plug/unplug support for the vfio-ap device. Note that only > >>> one > >>> vfi

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-08 Thread David Hildenbrand
On 08.01.19 20:52, Tony Krowiak wrote: > On 1/8/19 11:09 AM, David Hildenbrand wrote: >> On 08.01.19 17:01, Tony Krowiak wrote: >>> Introduces hot plug/unplug support for the vfio-ap device. Note that only >>> one >>> vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only >>>

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-08 Thread Tony Krowiak
On 1/8/19 11:09 AM, David Hildenbrand wrote: On 08.01.19 17:01, Tony Krowiak wrote: Introduces hot plug/unplug support for the vfio-ap device. Note that only one vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only be hot plugged if the '-device vfio-ap,sysfsdev=$path_to_md

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-08 Thread Tony Krowiak
On 1/8/19 11:01 AM, Tony Krowiak wrote: Introduces hot plug/unplug support for the vfio-ap device. Note that only one vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only be hot plugged if the '-device vfio-ap,sysfsdev=$path_to_mdev' option is not specified on the QEMU comma

Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-08 Thread David Hildenbrand
On 08.01.19 17:01, Tony Krowiak wrote: > Introduces hot plug/unplug support for the vfio-ap device. Note that only one > vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only be > hot plugged if the '-device vfio-ap,sysfsdev=$path_to_mdev' option is not > specified on the QEMU

[Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device

2019-01-08 Thread Tony Krowiak
Introduces hot plug/unplug support for the vfio-ap device. Note that only one vfio-ap device can be attached to the ap-bus, so a vfio-ap device can only be hot plugged if the '-device vfio-ap,sysfsdev=$path_to_mdev' option is not specified on the QEMU command line. Signed-off-by: Tony Krowiak Rev