On Thu, Mar 3, 2016 at 6:05 AM, Amit Shah wrote:
> On (Thu) 04 Feb 2016 [13:07:35], Ladi Prosek wrote:
>> - Original Message -
>> > - Original Message -
>> > >
>> > >
>> > > On 03/02/2016 13:36, Amit Shah wrote:
>> > > > ... and this can lead to breaking migration (the queue of req
On (Thu) 04 Feb 2016 [13:07:35], Ladi Prosek wrote:
> - Original Message -
> > - Original Message -
> > >
> > >
> > > On 03/02/2016 13:36, Amit Shah wrote:
> > > > ... and this can lead to breaking migration (the queue of requests on
> > > > the host needs to be migrated, else the
>>> It is already migrated as part of virtio_rng_save's call to virtio_save.
>>> On the loading side, virtio_rng_process condenses all requests into one
>>> and chr_read fills in as many virtqueue buffers as possible from the
>>> single request.
>>
>> Thanks! So this looks broken. The contract be
>
> Hi Pankaj,
>
> - Original Message -
> >
> > Hi Ladi,
> >
> > I think this is fine if we have multiple requests from Guests and
> > depending on entropy pool available we can honour individual requests
> > and return with the entropy.
> >
> > Just one point I have is, Suppose we ha
- Original Message -
> - Original Message -
> >
> >
> > On 03/02/2016 13:36, Amit Shah wrote:
> > > ... and this can lead to breaking migration (the queue of requests on
> > > the host needs to be migrated, else the new host will have no idea of
> > > the queue).
> >
> > It is al
Hi Pankaj,
- Original Message -
>
> Hi Ladi,
>
> I think this is fine if we have multiple requests from Guests and
> depending on entropy pool available we can honour individual requests
> and return with the entropy.
>
> Just one point I have is, Suppose we have multiple requests from
- Original Message -
>
>
> On 03/02/2016 13:36, Amit Shah wrote:
> > ... and this can lead to breaking migration (the queue of requests on
> > the host needs to be migrated, else the new host will have no idea of
> > the queue).
>
> It is already migrated as part of virtio_rng_save's cal
Hi Ladi,
I think this is fine if we have multiple requests from Guests and
depending on entropy pool available we can honour individual requests
and return with the entropy.
Just one point I have is, Suppose we have multiple requests from Guests
and we are returning if request length < 0 for
On 03/02/2016 13:36, Amit Shah wrote:
> ... and this can lead to breaking migration (the queue of requests on
> the host needs to be migrated, else the new host will have no idea of
> the queue).
It is already migrated as part of virtio_rng_save's call to virtio_save.
On the loading side, virti
Hi Amit,
- Original Message -
> Hi Ladi,
>
> Adding Pankaj to CC, he too looked at this recently.
>
> On (Fri) 22 Jan 2016 [13:19:58], Ladi Prosek wrote:
> > If the guest adds a buffer to the virtio queue while another buffer
> > is still pending and hasn't been filled and returned by th
Hi Ladi,
Adding Pankaj to CC, he too looked at this recently.
On (Fri) 22 Jan 2016 [13:19:58], Ladi Prosek wrote:
> If the guest adds a buffer to the virtio queue while another buffer
> is still pending and hasn't been filled and returned by the rng
> device, rng-random internally discards the pe
If the guest adds a buffer to the virtio queue while another buffer
is still pending and hasn't been filled and returned by the rng
device, rng-random internally discards the pending request, which
leads to the second buffer getting stuck in the queue. For the guest
this manifests as delayed comple
12 matches
Mail list logo
