Re: [Qemu-devel] [PATCH] rbd: shift byte count as a 64-bit value

2016-10-10 Thread Eric Blake
On 10/10/2016 03:00 PM, Paolo Bonzini wrote: > Otherwise, reads of more than 2GB fail. Until commit > 7bbca9e290a9c7c217b5a24fc6094e91e54bd05d, reads of 2^41 > bytes succeeded at least theoretically. I don't think the block layer ever passes a read request down to drivers that large in the first

[Qemu-devel] [PATCH] rbd: shift byte count as a 64-bit value

2016-10-10 Thread Paolo Bonzini
Otherwise, reads of more than 2GB fail. Until commit 7bbca9e290a9c7c217b5a24fc6094e91e54bd05d, reads of 2^41 bytes succeeded at least theoretically. In fact, pdiscard ought to receive a 64-bit integer as the count for the same reason. Reported by Coverity. Fixes: 7bbca9e290a9c7c217b5a24fc6094e9