Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2013-01-02 Thread Gerd Hoffmann
On 12/23/12 21:33, Alon Levy wrote: > On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: >> Hi, >> That is indeed a better solution, but it does change functionality. I think it is correct but I'd like to get some other opinions - Uri, Arnon, Yonit, Soren - any problems

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: > Hi, > > >> That is indeed a better solution, but it does change functionality. I > >> think it is correct but I'd like to get some other opinions - Uri, > >> Arnon, Yonit, Soren - any problems with dropping these? > >> > > Orientat

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Gerd Hoffmann
Hi, >> That is indeed a better solution, but it does change functionality. I >> think it is correct but I'd like to get some other opinions - Uri, >> Arnon, Yonit, Soren - any problems with dropping these? >> > Orientation is used in the Windows Display driver. It is used to set > dmDisplayOrien

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Yonit Halperin
On 12/13/2012 05:40 AM, Alon Levy wrote: On 12/06/12 16:41, Alon Levy wrote: RHBZ 869981 Before this patch revision < 4 (4 is the default) would result in a wrong qxl_rom size of 16384 instead of 8192 when building with spice-protocol-0.12, due to the addition of fields in the rom for client ca

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Alon Levy
> On 12/06/12 16:41, Alon Levy wrote: > > RHBZ 869981 > > > > Before this patch revision < 4 (4 is the default) would result in a > > wrong > > qxl_rom size of 16384 instead of 8192 when building with > > spice-protocol-0.12, due to the addition of fields in > > the rom for client capabilities and

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-12 Thread Gerd Hoffmann
On 12/06/12 16:41, Alon Levy wrote: > RHBZ 869981 > > Before this patch revision < 4 (4 is the default) would result in a wrong > qxl_rom size of 16384 instead of 8192 when building with > spice-protocol-0.12, due to the addition of fields in > the rom for client capabilities and monitors config t

[Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-06 Thread Alon Levy
RHBZ 869981 Before this patch revision < 4 (4 is the default) would result in a wrong qxl_rom size of 16384 instead of 8192 when building with spice-protocol-0.12, due to the addition of fields in the rom for client capabilities and monitors config that were added between spice-protocol 0.10 and 0