Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
> But there we are again at the level where going through the guest agent > might be a better way. "rpm -q kernel xorg-x11-drv-qxl" gives you what > you need ... Well, that relies on the agent working, and requires a lot of per-guest-os type of probing for the driver, as well as the fact that th

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
Hi, > I know that, but it would be possible to add code to the driver to > register a version string. Sure. Although it is a bit more complex that just a simple string. With qxl guest drivers moving to kms as we'll have two driver components then. > Might be useful for qxl developers, but not

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
On tis, 2012-11-20 at 11:17 +0100, Gerd Hoffmann wrote: > Hi, > > > I'm working on a kind of "troubleshooting log" option for gnome-boxes > > which wants to record all these kinds of data so that a helpdesk or a > > developer can help figuring out a problem with a guest. > > Understood. > > >

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Markus Armbruster
[Cc'ing Anthony because this could be of general QOM interest] Gerd Hoffmann writes: > On 11/19/12 14:11, Alexander Larsson wrote: >> This way you can easily tell from qemu if the guest is using >> a qxl driver or not. > > Device properties are for configuration, not inspection. Read-only prope

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
On 11/20/12 10:48, Markus Armbruster wrote: > [Cc'ing Anthony because this could be of general QOM interest] > > Gerd Hoffmann writes: > >> On 11/19/12 14:11, Alexander Larsson wrote: >>> This way you can easily tell from qemu if the guest is using >>> a qxl driver or not. >> >> Device propertie

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
Hi, > I'm working on a kind of "troubleshooting log" option for gnome-boxes > which wants to record all these kinds of data so that a helpdesk or a > developer can help figuring out a problem with a guest. Understood. > Knowing if a qxl > driver is in use is an important piece of information.

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
On tis, 2012-11-20 at 10:15 +0100, Gerd Hoffmann wrote: > On 11/20/12 10:07, Daniel P. Berrange wrote: > > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > >> On 11/19/12 14:11, Alexander Larsson wrote: > >>> This way you can easily tell from qemu if the guest is using > >>> a qxl d

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
On tis, 2012-11-20 at 10:48 +0100, Markus Armbruster wrote: > [Cc'ing Anthony because this could be of general QOM interest] > > Gerd Hoffmann writes: > > > On 11/19/12 14:11, Alexander Larsson wrote: > >> This way you can easily tell from qemu if the guest is using > >> a qxl driver or not. > >

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alon Levy
- Original Message - > On 11/20/12 10:07, Daniel P. Berrange wrote: > > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > >> On 11/19/12 14:11, Alexander Larsson wrote: > >>> This way you can easily tell from qemu if the guest is using > >>> a qxl driver or not. > >> > >> Dev

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
On 11/20/12 10:07, Daniel P. Berrange wrote: > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: >> On 11/19/12 14:11, Alexander Larsson wrote: >>> This way you can easily tell from qemu if the guest is using >>> a qxl driver or not. >> >> Device properties are for configuration, not i

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > On 11/19/12 14:11, Alexander Larsson wrote: > > This way you can easily tell from qemu if the guest is using > > a qxl driver or not. > > Device properties are for configuration, not inspection. Sounds like we need to expose somethi

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-19 Thread Gerd Hoffmann
On 11/19/12 14:11, Alexander Larsson wrote: > This way you can easily tell from qemu if the guest is using > a qxl driver or not. Device properties are for configuration, not inspection. cheers, Gerd

[Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-19 Thread Alexander Larsson
This way you can easily tell from qemu if the guest is using a qxl driver or not. --- hw/qxl.c | 1 + hw/qxl.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 1d16863..98af0bb 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -2261,6 +2261,7 @@ static Property