Re: [Qemu-devel] [PATCH] qom: avoid leaking str and bool properties on failure

2014-03-04 Thread Andreas Färber
Am 04.03.2014 15:28, schrieb Stefan Hajnoczi: > When object_property_add_str() and object_property_add_bool() fail, they > leak their internal StringProperty and BoolProperty structs. Remember > to free the structs on error. > > Luckily this is a low-impact memory leak since most QOM properties a

Re: [Qemu-devel] [PATCH] qom: avoid leaking str and bool properties on failure

2014-03-04 Thread Eric Blake
On 03/04/2014 07:28 AM, Stefan Hajnoczi wrote: > When object_property_add_str() and object_property_add_bool() fail, they > leak their internal StringProperty and BoolProperty structs. Remember > to free the structs on error. > > Luckily this is a low-impact memory leak since most QOM properties

[Qemu-devel] [PATCH] qom: avoid leaking str and bool properties on failure

2014-03-04 Thread Stefan Hajnoczi
When object_property_add_str() and object_property_add_bool() fail, they leak their internal StringProperty and BoolProperty structs. Remember to free the structs on error. Luckily this is a low-impact memory leak since most QOM properties are static qdev properties that will never take the error