Re: [Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-16 Thread Eduardo Habkost
On Wed, Apr 16, 2014 at 08:53:23AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Currently it is very easy to crash QEMU by issuing an object-add command > > using an abstract class or a class that doesn't support > > TYPE_USER_CREATABLE as parameter. > > > > Example: with the f

Re: [Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-15 Thread Markus Armbruster
Eduardo Habkost writes: > Currently it is very easy to crash QEMU by issuing an object-add command > using an abstract class or a class that doesn't support > TYPE_USER_CREATABLE as parameter. > > Example: with the following QMP command: > > (QEMU) object-add qom-type=cpu id=foo > > QEMU abor

Re: [Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-15 Thread Matthew Rosato
On 04/15/2014 04:01 PM, Eduardo Habkost wrote: > Currently it is very easy to crash QEMU by issuing an object-add command > using an abstract class or a class that doesn't support > TYPE_USER_CREATABLE as parameter. > > Example: with the following QMP command: > > (QEMU) object-add qom-type=c

[Qemu-devel] [PATCH] qmp: object-add: Validate class before creating object

2014-04-15 Thread Eduardo Habkost
Currently it is very easy to crash QEMU by issuing an object-add command using an abstract class or a class that doesn't support TYPE_USER_CREATABLE as parameter. Example: with the following QMP command: (QEMU) object-add qom-type=cpu id=foo QEMU aborts at: ERROR:qom/object.c:335:object