Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

2015-03-24 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:36:14PM +0100, Wolfgang Link wrote: > this qmp command returns the current link state from the given nic > this is impotent if the set_link failed or get an timeout. s/impotent/important/ I don't understand the rationale for this patch: set_link does not fail or time o

Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

2014-12-17 Thread Wolfgang
Tanks for your tips. 2014-12-17 10:02 GMT+01:00 Markus Armbruster : > > +if (queues == 0) { > > +error_set(errp, QERR_DEVICE_NOT_FOUND, name); > > +return (int64_t) -1; > > +} > > + > > +nc = ncs[0]; > > +ret = ncs[0]->link_down; > > + > > +if (nc->peer->info->

Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

2014-12-17 Thread Eric Blake
On 12/17/2014 02:02 AM, Markus Armbruster wrote: > Copying Eric for additional QAPI schema expertise. Thanks (not sure why I didn't see the original, as I usually notice emails that touch .json files) > > Wolfgang Link writes: > >> this qmp command returns the current link state from the given

Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

2014-12-17 Thread Markus Armbruster
Copying Eric for additional QAPI schema expertise. Wolfgang Link writes: > this qmp command returns the current link state from the given nic > this is impotent if the set_link failed or get an timeout. Please start your sentences with a capital letter, and end them with a period :) If "link s

[Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

2014-12-11 Thread Wolfgang Link
this qmp command returns the current link state from the given nic this is impotent if the set_link failed or get an timeout. Signed-off-by: Wolfgang Link --- net/net.c| 26 ++ qapi-schema.json | 15 +++ qmp-commands.hx | 22