Re: [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

2019-01-28 Thread Anton Kuchin
On 28/01/2019 18:37, Kevin Wolf wrote: Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben: This option is broken since a6baa60807 in v2.9 and returns mostly zeroes instead of real stats because actual querring of BlockStats that resides in blk is missing. And it makes no sense because with t

Re: [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

2019-01-28 Thread Thomas Huth
On 2019-01-28 16:15, Anton Kuchin wrote: > This option is broken since a6baa60807 in v2.9 and returns mostly > zeroes instead of real stats because actual querring of BlockStats s/querring/querying/ > that resides in blk is missing. > > And it makes no sense because with this option BlockDriverS

Re: [Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben: > This option is broken since a6baa60807 in v2.9 and returns mostly > zeroes instead of real stats because actual querring of BlockStats > that resides in blk is missing. > > And it makes no sense because with this option BlockDriverState-s > ar

[Qemu-devel] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

2019-01-28 Thread Anton Kuchin
This option is broken since a6baa60807 in v2.9 and returns mostly zeroes instead of real stats because actual querring of BlockStats that resides in blk is missing. And it makes no sense because with this option BlockDriverState-s are iterated but BlockAcctStats belong to BlockBackend and not BDS