Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-10 Thread Tomáš Golembiovský
On Tue, 3 Jul 2018 10:31:20 +0200 Tomáš Golembiovský wrote: > Report total file system size and free space in output of command > "guest-get-fsinfo". Values are optional and it is not an error if they cannot > be retrieved for some reason. > > Signed-off-by: Tomáš Golembiovský > --- > qga/com

Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 0b2c142da5d44a4b645dee47b7c50dae87a90a05.1530606672.git.tgole...@redhat.com Subject: [Qemu-devel] [PATCH] qga: report disk size and free space === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread Eric Blake
On 07/03/2018 05:54 AM, Tomáš Golembiovský wrote: On Tue, 3 Jul 2018 10:31:20 +0200 Tomáš Golembiovský wrote: diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 70ee5379f6..6d6ca05281 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -706,6 +706,22 @@ static GuestFil

Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread Eric Blake
On 07/03/2018 03:31 AM, Tomáš Golembiovský wrote: Report total file system size and free space in output of command "guest-get-fsinfo". Values are optional and it is not an error if they cannot be retrieved for some reason. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c | 18 +

Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread Tomáš Golembiovský
On Tue, 3 Jul 2018 10:31:20 +0200 Tomáš Golembiovský wrote: > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 70ee5379f6..6d6ca05281 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -706,6 +706,22 @@ static GuestFilesystemInfo *build_guest_fsinfo(char > *gu

Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread Tomáš Golembiovský
On Tue, 3 Jul 2018 12:01:55 +0200 Marc-André Lureau wrote: > Hi > > On Tue, Jul 3, 2018 at 10:31 AM, Tomáš Golembiovský > wrote: > > Report total file system size and free space in output of command > > "guest-get-fsinfo". Values are optional and it is not an error if they > > cannot > > be r

Re: [Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread Marc-André Lureau
Hi On Tue, Jul 3, 2018 at 10:31 AM, Tomáš Golembiovský wrote: > Report total file system size and free space in output of command > "guest-get-fsinfo". Values are optional and it is not an error if they cannot > be retrieved for some reason. > I am afraid this will miss 3.0, since it's a new fea

[Qemu-devel] [PATCH] qga: report disk size and free space

2018-07-03 Thread Tomáš Golembiovský
Report total file system size and free space in output of command "guest-get-fsinfo". Values are optional and it is not an error if they cannot be retrieved for some reason. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c | 18 ++ qga/commands-win32.c | 16