[Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-06-05 Thread Michael Roth
From: Gonglei token should be closed in all conditions. So move CloseHandle(token) to "out" branch. Signed-off-by: Wang Rui Signed-off-by: Gonglei Signed-off-by: Michael Roth --- qga/commands-win32.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-21 Thread Wangrui (K)
> -Original Message- > From: Yan Vugenfirer [mailto:yvuge...@redhat.com] > Sent: Wednesday, May 21, 2014 5:01 PM > To: Michael Roth > Cc: Luiz Capitulino; Wangrui (K); Gonglei (Arei); qemu-devel@nongnu.org; > arm...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] qg

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-21 Thread Yan Vugenfirer
On May 20, 2014, at 10:46 PM, Michael Roth wrote: > Quoting Luiz Capitulino (2014-05-20 14:17:42) >> On Mon, 19 May 2014 15:26:03 +0800 >> wrote: >> >>> From: Gonglei >>> >>> token should be closed in all conditions. >>> So move CloseHandle(token) to "out" branch. >> >> Looks good to me. Mi

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Michael Roth
Quoting Luiz Capitulino (2014-05-20 14:17:42) > On Mon, 19 May 2014 15:26:03 +0800 > wrote: > > > From: Gonglei > > > > token should be closed in all conditions. > > So move CloseHandle(token) to "out" branch. > > Looks good to me. Michael, are you going to pick this one? Sure I'll queue it.

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Luiz Capitulino
On Mon, 19 May 2014 15:26:03 +0800 wrote: > From: Gonglei > > token should be closed in all conditions. > So move CloseHandle(token) to "out" branch. Looks good to me. Michael, are you going to pick this one? > > Signed-off-by: Wang Rui > Signed-off-by: Gonglei > --- > qga/commands-win32.

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-20 Thread Yan Vugenfirer
On May 19, 2014, at 10:26 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > token should be closed in all conditions. > So move CloseHandle(token) to "out" branch. > > Signed-off-by: Wang Rui > Signed-off-by: Gonglei > --- > qga/commands-win32.c | 6 -- > 1 file changed, 4 insertions(

Re: [Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-19 Thread Eric Blake
On 05/19/2014 01:26 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > token should be closed in all conditions. > So move CloseHandle(token) to "out" branch. > > Signed-off-by: Wang Rui > Signed-off-by: Gonglei > --- > qga/commands-win32.c | 6 -- > 1 file changed, 4 insertions(+), 2

[Qemu-devel] [PATCH] qga: Fix handle fd leak in acquire_privilege()

2014-05-19 Thread arei.gonglei
From: Gonglei token should be closed in all conditions. So move CloseHandle(token) to "out" branch. Signed-off-by: Wang Rui Signed-off-by: Gonglei --- qga/commands-win32.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c ind