Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-18 Thread Peter Maydell
On 17 August 2016 at 08:35, Marc-André Lureau wrote: > fwiw, this crash can be reproduced with 2.5: it's not a regression. Imho, it > shouldn't prevent or delay 2.7. Thanks for checking. OK, let's not try to squeeze a fix into 2.7; better to investigate more carefully and try to line up our QemuO

Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-17 Thread Markus Armbruster
Markus Armbruster writes: > Michal Privoznik writes: > >> Program terminated with signal SIGSEGV, Segmentation fault. >> #0 0x55baf6ab4adc in qemu_opt_foreach (opts=0x0, func=0x55baf696b650 >> , opaque=0x7ffc51368c00, errp=0x7ffc51368e48) at >> util/qemu-option.c:617 >> 617 QTAILQ

Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-17 Thread Markus Armbruster
Michal Privoznik writes: > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x55baf6ab4adc in qemu_opt_foreach (opts=0x0, func=0x55baf696b650 > , opaque=0x7ffc51368c00, errp=0x7ffc51368e48) at > util/qemu-option.c:617 > 617 QTAILQ_FOREACH(opt, &opts->head, next) { >

Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-17 Thread Marc-André Lureau
Hi On Tue, Aug 16, 2016 at 7:18 PM Michal Privoznik wrote: > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x55baf6ab4adc in qemu_opt_foreach (opts=0x0, func=0x55baf696b650 > , opaque=0x7ffc51368c00, errp=0x7ffc51368e48) at > util/qemu-option.c:617 > 617 QTAILQ_FO

Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-17 Thread Markus Armbruster
Peter Maydell writes: > On 16 August 2016 at 16:17, Michal Privoznik wrote: >> The solution is to teach qemu_opt_foreach() to take a shortcut if >> @opts is NULL. Please provide a reproducer. A stack backtrace wouldn't hurt. >> >> Signed-off-by: Michal Privoznik >> --- >> >> Even after this

Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-16 Thread Peter Maydell
On 16 August 2016 at 16:17, Michal Privoznik wrote: > The solution is to teach qemu_opt_foreach() to take a shortcut if > @opts is NULL. > > Signed-off-by: Michal Privoznik > --- > > Even after this patch I'm still unable to attach vhost-user: > > {"id": "libvirt-20", "error": {"class": "GenericE

[Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-16 Thread Michal Privoznik
Program terminated with signal SIGSEGV, Segmentation fault. #0 0x55baf6ab4adc in qemu_opt_foreach (opts=0x0, func=0x55baf696b650 , opaque=0x7ffc51368c00, errp=0x7ffc51368e48) at util/qemu-option.c:617 617 QTAILQ_FOREACH(opt, &opts->head, next) { [Current thread is 1 (Thread 0x7f1d497