Re: [Qemu-devel] [PATCH] qemu-timer: remove unnecessary code

2016-07-13 Thread Cao jin
On 07/13/2016 07:40 PM, Paolo Bonzini wrote: On 13/07/2016 13:40, Cao jin wrote: On 07/13/2016 06:21 PM, Paolo Bonzini wrote: On 13/07/2016 11:06, Cao jin wrote: When passed argument 'ns' is 0, macro DIV_ROUND_UP will return 0 also. It's potentially slower though. Is it because th

Re: [Qemu-devel] [PATCH] qemu-timer: remove unnecessary code

2016-07-13 Thread Paolo Bonzini
On 13/07/2016 13:40, Cao jin wrote: > > > On 07/13/2016 06:21 PM, Paolo Bonzini wrote: >> >> >> On 13/07/2016 11:06, Cao jin wrote: >>> When passed argument 'ns' is 0, macro DIV_ROUND_UP will return 0 also. >> >> It's potentially slower though. >> > > Is it because the function in the i/o loop

Re: [Qemu-devel] [PATCH] qemu-timer: remove unnecessary code

2016-07-13 Thread Cao jin
On 07/13/2016 06:21 PM, Paolo Bonzini wrote: On 13/07/2016 11:06, Cao jin wrote: When passed argument 'ns' is 0, macro DIV_ROUND_UP will return 0 also. It's potentially slower though. Is it because the function in the i/o loop path, so the potentially extra arithmetical instructions ma

Re: [Qemu-devel] [PATCH] qemu-timer: remove unnecessary code

2016-07-13 Thread Paolo Bonzini
On 13/07/2016 11:06, Cao jin wrote: > When passed argument 'ns' is 0, macro DIV_ROUND_UP will return 0 also. It's potentially slower though. Paolo > Cc: Paolo Bonzini > Signed-off-by: Cao jin > --- > qemu-timer.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a

[Qemu-devel] [PATCH] qemu-timer: remove unnecessary code

2016-07-13 Thread Cao jin
When passed argument 'ns' is 0, macro DIV_ROUND_UP will return 0 also. Cc: Paolo Bonzini Signed-off-by: Cao jin --- qemu-timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index eb22e92..cfe0893 100644 --- a/qemu-timer.c +++ b/qemu-timer