Re: [Qemu-devel] [PATCH] qemu-sockets: simplify error handling

2016-01-30 Thread Michael Tokarev
22.01.2016 14:28, Paolo Bonzini wrote: > Just go always through the err label. (Noticed because Coverity > complains that peer is always non-NULL in the error cleanup code, > but removing the "if" is arguably more prone to introducing the > opposite bug in the future). Applied to -trivial, thanks

Re: [Qemu-devel] [PATCH] qemu-sockets: simplify error handling

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 12:28:33PM +0100, Paolo Bonzini wrote: > Just go always through the err label. (Noticed because Coverity > complains that peer is always non-NULL in the error cleanup code, > but removing the "if" is arguably more prone to introducing the > opposite bug in the future). > >

[Qemu-devel] [PATCH] qemu-sockets: simplify error handling

2016-01-22 Thread Paolo Bonzini
Just go always through the err label. (Noticed because Coverity complains that peer is always non-NULL in the error cleanup code, but removing the "if" is arguably more prone to introducing the opposite bug in the future). Signed-off-by: Paolo Bonzini --- util/qemu-sockets.c | 6 +++--- 1 file