Re: [Qemu-devel] [PATCH] qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts

2015-10-12 Thread Daniel P. Berrange
On Mon, Oct 12, 2015 at 03:35:41PM +0200, Paolo Bonzini wrote: > The QemuOpts-based code treats "option not set" and "option set > to false" the same way for the ipv4 and ipv6 options, because it > is meant to handle only the ",ipv4" and ",ipv6" substrings in > hand-crafted option parsers. > > Whe

[Qemu-devel] [PATCH] qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts

2015-10-12 Thread Paolo Bonzini
The QemuOpts-based code treats "option not set" and "option set to false" the same way for the ipv4 and ipv6 options, because it is meant to handle only the ",ipv4" and ",ipv6" substrings in hand-crafted option parsers. When converting InetSocketAddress to QemuOpts, however, it is necessary to han