Re: [Qemu-devel] [PATCH] qemu-pr-helper: Actually allow users to specify pidfile

2018-03-24 Thread Eric Blake
On 03/24/2018 12:14 AM, Michal Privoznik wrote: Due to wrong specification of arguments to getopt_long() any attempt to set pidfile resulted in: 1) the default to be leaked 2) the @pidfile variable to be set to NULL (because optarg is NULL without this patch). Broken in introduction with commi

[Qemu-devel] [PATCH] qemu-pr-helper: Actually allow users to specify pidfile

2018-03-23 Thread Michal Privoznik
Due to wrong specification of arguments to getopt_long() any attempt to set pidfile resulted in: 1) the default to be leaked 2) the @pidfile variable to be set to NULL (because optarg is NULL without this patch). Signed-off-by: Michal Privoznik --- scsi/qemu-pr-helper.c | 7 --- 1 file chan