Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-28 Thread P J P
+-- On Tue, 27 Jun 2017, Eric Blake wrote --+ | > $ qemu-nbd -x foo -f raw -t null-co:// & | > [1] 12726 | > $ qemu-io -c quit nbd://localhost/bar | > can't open device nbd://localhost/bar: No export with name 'bar' available | > [1] + 12726 broken pipe qemu-nbd -x foo -f raw -t null-co:// | > |

Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-28 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 04:27:00PM +0200, Max Reitz wrote: > On 2017-06-27 19:09, Eric Blake wrote: > > On 06/11/2017 07:37 AM, Max Reitz wrote: > >> qemu proper has done so for 13 years > >> (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have > >> done so for four years (526eda14

Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-28 Thread Max Reitz
On 2017-06-27 19:09, Eric Blake wrote: > On 06/11/2017 07:37 AM, Max Reitz wrote: >> qemu proper has done so for 13 years >> (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have >> done so for four years (526eda14a68d5b3596be715505289b541288ef2a). >> Ignoring this signal is especia

Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-27 Thread Eric Blake
On 06/11/2017 07:37 AM, Max Reitz wrote: > qemu proper has done so for 13 years > (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have > done so for four years (526eda14a68d5b3596be715505289b541288ef2a). > Ignoring this signal is especially important in qemu-nbd because > otherwise

Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-12 Thread Stefan Hajnoczi
On Sun, Jun 11, 2017 at 02:37:14PM +0200, Max Reitz wrote: > qemu proper has done so for 13 years > (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have > done so for four years (526eda14a68d5b3596be715505289b541288ef2a). > Ignoring this signal is especially important in qemu-nbd b

Re: [Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-12 Thread Paolo Bonzini
On 11/06/2017 14:37, Max Reitz wrote: > qemu proper has done so for 13 years > (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have > done so for four years (526eda14a68d5b3596be715505289b541288ef2a). > Ignoring this signal is especially important in qemu-nbd because > otherwise

[Qemu-devel] [PATCH] qemu-nbd: Ignore SIGPIPE

2017-06-11 Thread Max Reitz
qemu proper has done so for 13 years (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have done so for four years (526eda14a68d5b3596be715505289b541288ef2a). Ignoring this signal is especially important in qemu-nbd because otherwise a client can easily take down the qemu-nbd server