Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 2:31 PM, Marc-Antoine Perennou wrote: > On 10 June 2011 09:14, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 9 June 2011 18:44, Andreas Färber wrote: Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: > Manually including stddef.h or replacing N

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > pulse/simple.h does not include stdlib.h > We cannot use NULL since it may not be defined > Use 0 instead > > Signed-off-by: Marc-Antoine Perennou > --- > configure |2 +- > 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Marc-Antoine Perennou
On 10 June 2011 09:14, Markus Armbruster wrote: > Peter Maydell writes: > >> On 9 June 2011 18:44, Andreas Färber wrote: >>> Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: Manually including stddef.h or replacing NULL by 0 or (void*)0 makes it work. >>> >>> Then please submit a

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-10 Thread Markus Armbruster
Peter Maydell writes: > On 9 June 2011 18:44, Andreas Färber wrote: >> Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: >>> Manually including stddef.h or replacing NULL by 0 or (void*)0 makes it >>> work. >> >> Then please submit a new patch that explicit includes that header with a >> com

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Peter Maydell
On 9 June 2011 18:44, Andreas Färber wrote: > Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: >> Manually including stddef.h or replacing NULL by 0 or (void*)0 makes it >> work. > > Then please submit a new patch that explicit includes that header with a > comment explaining why, so that it

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Markus Armbruster
Aurelien Jarno writes: > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: >> pulse/simple.h does not include stdlib.h >> We cannot use NULL since it may not be defined >> Use 0 instead > > I am unable to reproduce this issue, even with gcc-4.6. Also please note > that NULL i

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Andreas Färber
Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: On 4 June 2011 00:54, malc wrote: On Sat, 4 Jun 2011, Aurelien Jarno wrote: On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: On Fri, 3 Jun 2011, Aurelien Jarno wrote: On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-09 Thread Marc-Antoine Perennou
On 4 June 2011 00:54, malc wrote: > On Sat, 4 Jun 2011, Aurelien Jarno wrote: > >> On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: >> > On Fri, 3 Jun 2011, Aurelien Jarno wrote: >> > >> > > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: >> > > > pulse/simple.h does no

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-03 Thread malc
On Sat, 4 Jun 2011, Aurelien Jarno wrote: > On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: > > On Fri, 3 Jun 2011, Aurelien Jarno wrote: > > > > > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > > > > pulse/simple.h does not include stdlib.h > > > > We cannot use N

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-03 Thread Aurelien Jarno
On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: > On Fri, 3 Jun 2011, Aurelien Jarno wrote: > > > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > > > pulse/simple.h does not include stdlib.h > > > We cannot use NULL since it may not be defined > > > Use 0 instead > >

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-03 Thread malc
On Fri, 3 Jun 2011, Aurelien Jarno wrote: > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > > pulse/simple.h does not include stdlib.h > > We cannot use NULL since it may not be defined > > Use 0 instead > > I am unable to reproduce this issue, even with gcc-4.6. Also ple

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-03 Thread Aurelien Jarno
On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > pulse/simple.h does not include stdlib.h > We cannot use NULL since it may not be defined > Use 0 instead I am unable to reproduce this issue, even with gcc-4.6. Also please note that NULL is defined in , not . is included

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-05-27 Thread Marc-Antoine Perennou
Any chance to get this reviewed/applied any time soon ? It currently does not build without it with gcc 4.6.0 On 29 April 2011 17:59, Marc-Antoine Perennou wrote: > pulse/simple.h does not include stdlib.h > We cannot use NULL since it may not be defined > Use 0 instead > > Signed-off-by: Marc-An

[Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-04-29 Thread Marc-Antoine Perennou
pulse/simple.h does not include stdlib.h We cannot use NULL since it may not be defined Use 0 instead Signed-off-by: Marc-Antoine Perennou --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index ea8b676..d67c3ce 100755 --- a/configure +