Re: [Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Max Reitz
On 30.10.2015 19:04, Jeff Cody wrote: > On Fri, Oct 30, 2015 at 06:16:29PM +0100, Max Reitz wrote: >> On 29.10.2015 19:04, Jeff Cody wrote: >>> Commit 934659c switched the iotests to run qemu-io from a bash subshell, >>> in order to catch segfaults. This method is incompatible with the >>> current

Re: [Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Jeff Cody
On Fri, Oct 30, 2015 at 06:16:29PM +0100, Max Reitz wrote: > On 29.10.2015 19:04, Jeff Cody wrote: > > Commit 934659c switched the iotests to run qemu-io from a bash subshell, > > in order to catch segfaults. This method is incompatible with the > > current valgrind_qemu_io() bash function. > > >

Re: [Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-30 Thread Max Reitz
On 29.10.2015 19:04, Jeff Cody wrote: > Commit 934659c switched the iotests to run qemu-io from a bash subshell, > in order to catch segfaults. This method is incompatible with the > current valgrind_qemu_io() bash function. > > Move the valgrind usage into the exec subshell in _qemu_io_wrapper()

[Qemu-devel] [PATCH] qemu-iotests: fix -valgrind option for check

2015-10-29 Thread Jeff Cody
Commit 934659c switched the iotests to run qemu-io from a bash subshell, in order to catch segfaults. This method is incompatible with the current valgrind_qemu_io() bash function. Move the valgrind usage into the exec subshell in _qemu_io_wrapper(), while making sure the original return value is