Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben: >> On Wed, 05/14 15:12, Markus Armbruster wrote: >> > The shell script attempts to suppress core dumps like this: >> > >> > old_ulimit=$(ulimit -c) >> > ulimit -c 0 >> > $QEMU_IO arg... >> > ulimit -c "$old_ul

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben: > On Wed, 05/14 15:12, Markus Armbruster wrote: > > The shell script attempts to suppress core dumps like this: > > > > old_ulimit=$(ulimit -c) > > ulimit -c 0 > > $QEMU_IO arg... > > ulimit -c "$old_ulimit" > > > > This breaks the

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Fam Zheng
On Wed, 05/14 15:12, Markus Armbruster wrote: > The shell script attempts to suppress core dumps like this: > > old_ulimit=$(ulimit -c) > ulimit -c 0 > $QEMU_IO arg... > ulimit -c "$old_ulimit" > > This breaks the test hard unless the limit was zero to begin with! > ulimit sets bo

[Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Markus Armbruster
The shell script attempts to suppress core dumps like this: old_ulimit=$(ulimit -c) ulimit -c 0 $QEMU_IO arg... ulimit -c "$old_ulimit" This breaks the test hard unless the limit was zero to begin with! ulimit sets both hard and soft limit by default, and (re-)raising the hard lim

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Kevin Wolf
Am 14.05.2014 um 13:16 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > Kevin Wolf writes: > > > >> Am 13.05.2014 um 19:44 hat Markus Armbruster geschrieben: > >>> Fam Zheng writes: > >>> > >>> > On Tue, 05/13 10:46, Markus Armbruster wrote: > >>> >> The shell script attemp

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 13.05.2014 um 19:44 hat Markus Armbruster geschrieben: >>> Fam Zheng writes: >>> >>> > On Tue, 05/13 10:46, Markus Armbruster wrote: >>> >> The shell script attempts to suppress core dumps like this: >>> >> >>> >> old_ulimit=$(ulimit

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.05.2014 um 19:44 hat Markus Armbruster geschrieben: >> Fam Zheng writes: >> >> > On Tue, 05/13 10:46, Markus Armbruster wrote: >> >> The shell script attempts to suppress core dumps like this: >> >> >> >> old_ulimit=$(ulimit -c) >> >> ulimit -c 0 >> >> $Q

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-14 Thread Kevin Wolf
Am 13.05.2014 um 19:44 hat Markus Armbruster geschrieben: > Fam Zheng writes: > > > On Tue, 05/13 10:46, Markus Armbruster wrote: > >> The shell script attempts to suppress core dumps like this: > >> > >> old_ulimit=$(ulimit -c) > >> ulimit -c 0 > >> $QEMU_IO arg... > >> ulimit -

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-13 Thread Eric Blake
On 05/13/2014 11:44 AM, Markus Armbruster wrote: >> But when I try to put this in a function to avoid repeating: >> >> function _no_dump_exec() >> { >> (ulimit -c 0; exec "$@") >> } >> >> _no_dump_exec $QEMU_IO -c "write -P 0x5a 0 512" -c "abort" "$TEST_IMG") >> | _filter_

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-13 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 05/13 10:46, Markus Armbruster wrote: >> The shell script attempts to suppress core dumps like this: >> >> old_ulimit=$(ulimit -c) >> ulimit -c 0 >> $QEMU_IO arg... >> ulimit -c "$old_ulimit" >> >> This breaks the test hard unless the limit was zero t

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-13 Thread Fam Zheng
On Tue, 05/13 13:30, Markus Armbruster wrote: > Fam Zheng writes: > > > On Tue, 05/13 10:46, Markus Armbruster wrote: > >> The shell script attempts to suppress core dumps like this: > >> > >> old_ulimit=$(ulimit -c) > >> ulimit -c 0 > >> $QEMU_IO arg... > >> ulimit -c "$old_ulim

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-13 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 05/13 10:46, Markus Armbruster wrote: >> The shell script attempts to suppress core dumps like this: >> >> old_ulimit=$(ulimit -c) >> ulimit -c 0 >> $QEMU_IO arg... >> ulimit -c "$old_ulimit" >> >> This breaks the test hard unless the limit was zero t

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-13 Thread Fam Zheng
On Tue, 05/13 10:46, Markus Armbruster wrote: > The shell script attempts to suppress core dumps like this: > > old_ulimit=$(ulimit -c) > ulimit -c 0 > $QEMU_IO arg... > ulimit -c "$old_ulimit" > > This breaks the test hard unless the limit was zero to begin with! > ulimit sets bo

[Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-13 Thread Markus Armbruster
The shell script attempts to suppress core dumps like this: old_ulimit=$(ulimit -c) ulimit -c 0 $QEMU_IO arg... ulimit -c "$old_ulimit" This breaks the test hard unless the limit was zero to begin with! ulimit sets both hard and soft limit by default, and (re-)raising the hard lim