Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis

2014-03-12 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 10:23:00PM +0100, Stefan Weil wrote: > Smatch complains about several global symbols which should be local. > > Add the missing 'static' attributes and move the 'extern' declaration > of variable qemuio_misalign to qemu-io.h. This variable also changes > the type from 'int'

Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 10:23:00PM +0100, Stefan Weil wrote: > Smatch complains about several global symbols which should be local. > > Add the missing 'static' attributes and move the 'extern' declaration > of variable qemuio_misalign to qemu-io.h. This variable also changes > the type from 'int'

[Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis

2014-03-05 Thread Stefan Weil
Smatch complains about several global symbols which should be local. Add the missing 'static' attributes and move the 'extern' declaration of variable qemuio_misalign to qemu-io.h. This variable also changes the type from 'int' to 'bool' which better fits documents its use. Signed-off-by: Stefan