Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2018-02-02 Thread Max Reitz
On 2018-02-02 14:37, Max Reitz wrote: > On 2017-12-02 23:37, Shravan Rajinikanth wrote: >> Signed-off-by: Shravan Rajinikanth >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 68b375f..bea9268 100644 >> --- a/qemu-img

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2018-02-02 Thread Max Reitz
On 2017-12-02 23:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ sta

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-04 Thread Shravan Rajinikanth
> To me both versions seem fine, could you explain the grammatical error in the > old message? My opinion aligns with Peter's, in that "This means" followed by "waste of" is a break in the sentence to a reader. Adding an "a" to change it to "This means a waste of" also seemed like a possible fix,

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 15:51, Max Reitz wrote: > On 2017-12-02 23:37, Shravan Rajinikanth wrote: >> Signed-off-by: Shravan Rajinikanth >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 68b375f..bea9268 100644 >> --- a

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-04 Thread Max Reitz
On 2017-12-02 23:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ sta

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-04 Thread Fam Zheng
On Sat, 12/02 14:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ sta

[Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-02 Thread Shravan Rajinikanth
Signed-off-by: Shravan Rajinikanth --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 68b375f..bea9268 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet)