Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-16 Thread Amit Shah
On (Thu) 16 Jul 2015 [10:11:04], Nils Carlson wrote: > On Thu, 16 Jul 2015, Amit Shah wrote: > > >On (Wed) 15 Jul 2015 [23:44:52], Nils Carlson wrote: > >>On Mon, 13 Jul 2015, Nils Carlson wrote: > >> > >>>On Mon, 13 Jul 2015, Amit Shah wrote: > >> > >> > >> > Also, returning TRUE there isn't

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-16 Thread Nils Carlson
On Thu, 16 Jul 2015, Amit Shah wrote: On (Wed) 15 Jul 2015 [23:44:52], Nils Carlson wrote: On Mon, 13 Jul 2015, Nils Carlson wrote: On Mon, 13 Jul 2015, Amit Shah wrote: Also, returning TRUE there isn't right - if the connection ends, we should return FALSE. I agree that this seems rea

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-15 Thread Amit Shah
On (Wed) 15 Jul 2015 [23:44:52], Nils Carlson wrote: > On Mon, 13 Jul 2015, Nils Carlson wrote: > > >On Mon, 13 Jul 2015, Amit Shah wrote: > > > > >>Also, returning TRUE there isn't right - if the connection ends, we > >>should return FALSE. > > > >I agree that this seems reasonable. I will cha

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-15 Thread Nils Carlson
On Mon, 13 Jul 2015, Nils Carlson wrote: On Mon, 13 Jul 2015, Amit Shah wrote: Also, returning TRUE there isn't right - if the connection ends, we should return FALSE. I agree that this seems reasonable. I will change it and re-test. I had a closer look, and it seems always returning t

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-13 Thread Nils Carlson
On Mon, 13 Jul 2015, Amit Shah wrote: On (Mon) 13 Jul 2015 [12:15:22], Paolo Bonzini wrote: On 13/07/2015 10:13, pyssl...@ludd.ltu.se wrote: Commit 812c1057 introduced HUP detection on unix and tcp sockets prior to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2 which relied

[Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-13 Thread pyssling
From: Nils Carlson Commit 812c1057 introduced HUP detection on unix and tcp sockets prior to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2 which relied on the old behaviour where data on a socket was readable even if a HUP was present. On Linux a working solution seems to be to

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [12:15:22], Paolo Bonzini wrote: > > > On 13/07/2015 10:13, pyssl...@ludd.ltu.se wrote: > > Commit 812c1057 introduced HUP detection on unix and tcp sockets prior > > to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2 > > which relied on the old behaviour wher

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 10:13, pyssl...@ludd.ltu.se wrote: > Commit 812c1057 introduced HUP detection on unix and tcp sockets prior > to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2 > which relied on the old behaviour where data on a socket was readable > even if a HUP was present. > >