Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-17 Thread Zifei Tong
On Tue, Sep 16, 2014 at 11:30 PM, Kirill Batuzov wrote: > On Tue, 16 Sep 2014, Markus Armbruster wrote: > >> >> Kirill, you added the code being changed. Could you review the patch? >> > > I'll try but this is more about GIOConditions which I do not understand > well. See below. > > Zifei Tong w

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-16 Thread Kirill Batuzov
On Tue, 16 Sep 2014, Markus Armbruster wrote: > > Kirill, you added the code being changed. Could you review the patch? > I'll try but this is more about GIOConditions which I do not understand well. See below. Zifei Tong writes: > After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handl

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-16 Thread Zifei Tong
On Tue, Sep 16, 2014 at 2:06 PM, Markus Armbruster wrote: > Cc'ing Gerd for additional chardev expertise. > > Zifei Tong writes: > >> After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP >> in tcp_chr_read for tcp chardev), the connection is disconnected when in >> G_IO_HUP cond

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-15 Thread Markus Armbruster
Cc'ing Gerd for additional chardev expertise. Zifei Tong writes: > After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP > in tcp_chr_read for tcp chardev), the connection is disconnected when in > G_IO_HUP condition. > > However, it's possible that the channel is in G_IO_IN con

Re: [Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-15 Thread Zifei Tong
Friendly ping. Also CC to qemu-trivial. On Sun, Sep 7, 2014 at 8:24 PM, Zifei Tong wrote: > After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP > in tcp_chr_read for tcp chardev), the connection is disconnected when in > G_IO_HUP condition. > > However, it's possible that the

[Qemu-devel] [PATCH] qemu-char: Do not disconnect when there's data for reading

2014-09-07 Thread Zifei Tong
After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP in tcp_chr_read for tcp chardev), the connection is disconnected when in G_IO_HUP condition. However, it's possible that the channel is in G_IO_IN condition at the same time, meaning there is data for reading. In that case, the