Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-10-09 Thread Lai Jiangshan
On 09/26/2011 04:21 PM, Avi Kivity wrote: > On 09/25/2011 08:22 PM, Jan Kiszka wrote: >> On 2011-09-25 16:07, Avi Kivity wrote: >> > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> >> > Moreover: wrong indention. >> >> > >> >> > You know that this won't work for qemu-kvm with in-kernel irqc

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-26 Thread Avi Kivity
On 09/25/2011 08:22 PM, Jan Kiszka wrote: On 2011-09-25 16:07, Avi Kivity wrote: > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> > Moreover: wrong indention. >> > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? You >> > may want to provide a patch for that tre

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-25 Thread Jan Kiszka
On 2011-09-25 16:07, Avi Kivity wrote: > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> > Moreover: wrong indention. >> > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? You >> > may want to provide a patch for that tree, emulating the unavailable >> > LINT1 injection v

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-25 Thread Avi Kivity
On 09/23/2011 12:31 PM, Lai Jiangshan wrote: > Moreover: wrong indention. > > You know that this won't work for qemu-kvm with in-kernel irqchip? You > may want to provide a patch for that tree, emulating the unavailable > LINT1 injection via testing the APIC configration and then raising an >

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-23 Thread Jan Kiszka
On 2011-09-23 11:31, Lai Jiangshan wrote: > On 09/22/2011 10:51 PM, Jan Kiszka wrote: >> On 2011-09-22 11:50, Lai Jiangshan wrote: >>> >>> From: KAMEZAWA Hiroyuki >>> Subject: [PATCH] Fix inject-nmi >>> >>> Now, inject-nmi sends NMI to all cpus...but this doesn't emulate >>> pc hardware 'NMI butto

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-23 Thread Lai Jiangshan
On 09/22/2011 10:51 PM, Jan Kiszka wrote: > On 2011-09-22 11:50, Lai Jiangshan wrote: >> >> From: KAMEZAWA Hiroyuki >> Subject: [PATCH] Fix inject-nmi >> >> Now, inject-nmi sends NMI to all cpus...but this doesn't emulate >> pc hardware 'NMI button', which triggers LINT1. >> >> So, now, LINT1 mask

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-22 Thread Jan Kiszka
On 2011-09-22 11:50, Lai Jiangshan wrote: > > From: KAMEZAWA Hiroyuki > Subject: [PATCH] Fix inject-nmi > > Now, inject-nmi sends NMI to all cpus...but this doesn't emulate > pc hardware 'NMI button', which triggers LINT1. > > So, now, LINT1 mask is ignored by inject-nmi and NMIs are sent to >

[Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-22 Thread Lai Jiangshan
From: KAMEZAWA Hiroyuki Subject: [PATCH] Fix inject-nmi Now, inject-nmi sends NMI to all cpus...but this doesn't emulate pc hardware 'NMI button', which triggers LINT1. So, now, LINT1 mask is ignored by inject-nmi and NMIs are sent to all cpus without checking LINT1 mask. Because Linux masks L