Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386

2012-04-02 Thread Andreas Färber
Am 31.03.2012 18:46, schrieb Olaf Hering: > On Sat, Mar 31, Andreas Färber wrote: > >> This is the only usage of += outside Makefile fragments, so I wonder if >> its use may have been by accident. Is it safe in a POSIX context? >> Or should we better use CFLAGS="$CFLAGS -march=486"? > > Now that

Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386

2012-03-31 Thread Olaf Hering
On Sat, Mar 31, Peter Maydell wrote: > On 31 March 2012 16:41, Andreas Färber wrote: > > This is the only usage of += outside Makefile fragments, so I wonder if > > its use may have been by accident. Is it safe in a POSIX context? > > Or should we better use CFLAGS="$CFLAGS -march=486"? > > For Q

Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386

2012-03-31 Thread Peter Maydell
On 31 March 2012 16:41, Andreas Färber wrote: > This is the only usage of += outside Makefile fragments, so I wonder if > its use may have been by accident. Is it safe in a POSIX context? > Or should we better use CFLAGS="$CFLAGS -march=486"? > For QEMU_CFLAGS we use the pattern QEMU_CFLAGS="-opti

Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386

2012-03-31 Thread Olaf Hering
On Sat, Mar 31, Andreas Färber wrote: > This is the only usage of += outside Makefile fragments, so I wonder if > its use may have been by accident. Is it safe in a POSIX context? > Or should we better use CFLAGS="$CFLAGS -march=486"? Now that I look at the shebang, configure is a sh script and +

Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386

2012-03-31 Thread Andreas Färber
Hi Olaf, Am 30.03.2012 17:24, schrieb Olaf Hering: > > configure will generate incorrect CFLAGS which will lead to compile > errors due to unknown gcc options, IFF CFLAGS was already in the > environment during configure invocation. > > Add a space before the -march=i486 gcc option. > > This pa

[Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386

2012-03-30 Thread Olaf Hering
configure will generate incorrect CFLAGS which will lead to compile errors due to unknown gcc options, IFF CFLAGS was already in the environment during configure invocation. Add a space before the -march=i486 gcc option. This patch is against the qemu-xen tree, but it should apply also to qemu.g