Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Andreas Färber writes: > Am 07.01.2013 23:20, schrieb Peter Maydell: >> On 7 January 2013 22:10, Andreas Färber wrote: >>> Am 07.01.2013 21:16, schrieb Peter Maydell: On 7 January 2013 20:12, Anthony Liguori wrote: > Peter Maydell writes: >> It seems to me like arbitrarily allowin

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Andreas Färber
Am 07.01.2013 23:20, schrieb Peter Maydell: > On 7 January 2013 22:10, Andreas Färber wrote: >> Am 07.01.2013 21:16, schrieb Peter Maydell: >>> On 7 January 2013 20:12, Anthony Liguori wrote: Peter Maydell writes: > It seems to me like arbitrarily allowing the monitor to construct >

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Peter Maydell
On 7 January 2013 22:10, Andreas Färber wrote: > Am 07.01.2013 21:16, schrieb Peter Maydell: >> On 7 January 2013 20:12, Anthony Liguori wrote: >>> Peter Maydell writes: It seems to me like arbitrarily allowing the monitor to construct no-user devices isn't really the right way to atta

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Andreas Färber
Am 07.01.2013 21:16, schrieb Peter Maydell: > On 7 January 2013 20:12, Anthony Liguori wrote: >> Peter Maydell writes: >>> It seems to me like arbitrarily allowing the monitor to construct >>> no-user devices isn't really the right way to attack the problem >>> of "allow complete machine construc

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Christian Borntraeger writes: > On 07/01/13 20:32, Anthony Liguori wrote: >> Christian Borntraeger writes: >> >>> since >>> >>> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >>> qdev: refactor device creation to allow bus_info to be set only in class >>> >>> A user can specify a device that i

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Peter Maydell writes: > On 7 January 2013 20:12, Anthony Liguori wrote: >> Peter Maydell writes: >>> It seems to me like arbitrarily allowing the monitor to construct >>> no-user devices isn't really the right way to attack the problem >>> of "allow complete machine construction by management t

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Christian Borntraeger
On 07/01/13 20:32, Anthony Liguori wrote: > Christian Borntraeger writes: > >> since >> >> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >> qdev: refactor device creation to allow bus_info to be set only in class >> >> A user can specify a device that is no_user. >> For example on my i386 box,

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Peter Maydell
On 7 January 2013 20:12, Anthony Liguori wrote: > Peter Maydell writes: >> It seems to me like arbitrarily allowing the monitor to construct >> no-user devices isn't really the right way to attack the problem >> of "allow complete machine construction by management tools"... > > There is no such

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Peter Maydell writes: > On 7 January 2013 19:32, Anthony Liguori wrote: >> Christian Borntraeger writes: >> >>> since >>> >>> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >>> qdev: refactor device creation to allow bus_info to be set only in class >>> >>> A user can specify a device that is

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Peter Maydell
On 7 January 2013 19:32, Anthony Liguori wrote: > Christian Borntraeger writes: > >> since >> >> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >> qdev: refactor device creation to allow bus_info to be set only in class >> >> A user can specify a device that is no_user. >> For example on my i386

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Christian Borntraeger writes: > since > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > qdev: refactor device creation to allow bus_info to be set only in class > > A user can specify a device that is no_user. > For example on my i386 box, I can add a 2nd kvmvapic device. > > This patch check

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Luiz Capitulino
On Mon, 07 Jan 2013 15:20:17 +0100 Andreas Färber wrote: > Am 17.12.2012 17:00, schrieb Christian Borntraeger: > > since > > > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > > qdev: refactor device creation to allow bus_info to be set only in class > > > > A user can specify a device that

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Andreas Färber
Am 17.12.2012 17:00, schrieb Christian Borntraeger: > since > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > qdev: refactor device creation to allow bus_info to be set only in class > > A user can specify a device that is no_user. > For example on my i386 box, I can add a 2nd kvmvapic device

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Christian Borntraeger
Ping? On 17/12/12 17:00, Christian Borntraeger wrote: > since > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > qdev: refactor device creation to allow bus_info to be set only in class > > A user can specify a device that is no_user. > For example on my i386 box, I can add a 2nd kvmvapic de

[Qemu-devel] [PATCH] qdev: obey no_user

2012-12-17 Thread Christian Borntraeger
since commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 qdev: refactor device creation to allow bus_info to be set only in class A user can specify a device that is no_user. For example on my i386 box, I can add a 2nd kvmvapic device. This patch checks for no-user and rejects the device_add. Sign