Re: [Qemu-devel] [PATCH] qdev: Remove some non-run codes in qdev_walk_children().

2011-08-11 Thread Zhi Yong Wu
On Fri, Aug 12, 2011 at 3:40 AM, Anthony Liguori wrote: > On 08/07/2011 11:15 PM, Zhi Yong Wu wrote: >> >> As you have known, qdev_reset_one() forever return a ZERO value to its >> caller, so some branches can not be forever covered in qdev_walk_children(). >> >> I thought that the return value fo

Re: [Qemu-devel] [PATCH] qdev: Remove some non-run codes in qdev_walk_children().

2011-08-11 Thread Anthony Liguori
On 08/07/2011 11:15 PM, Zhi Yong Wu wrote: As you have known, qdev_reset_one() forever return a ZERO value to its caller, so some branches can not be forever covered in qdev_walk_children(). I thought that the return value for dev->info->reset(dev) can be returned, but dev->info->reset(dev) is

[Qemu-devel] [PATCH] qdev: Remove some non-run codes in qdev_walk_children().

2011-08-07 Thread Zhi Yong Wu
As you have known, qdev_reset_one() forever return a ZERO value to its caller, so some branches can not be forever covered in qdev_walk_children(). I thought that the return value for dev->info->reset(dev) can be returned, but dev->info->reset(dev) is referring to a function with void type. Sig