Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-02-22 Thread Eduardo Habkost
On Tue, Jan 03, 2017 at 03:06:02PM -0200, Eduardo Habkost wrote: > (CCing libvir-list and Laine) > > On Tue, Jan 03, 2017 at 05:53:27PM +0100, Igor Mammedov wrote: > > On Tue, 3 Jan 2017 17:10:15 +0100 > > Paolo Bonzini wrote: > > > > > > > > > > > On 03/01/2017 15:22, Eduardo Habkost wrote: >

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Eduardo Habkost
(CCing libvir-list and Laine) On Tue, Jan 03, 2017 at 05:53:27PM +0100, Igor Mammedov wrote: > On Tue, 3 Jan 2017 17:10:15 +0100 > Paolo Bonzini wrote: > > > > > > > On 03/01/2017 15:22, Eduardo Habkost wrote: > > >> I didn't know that. Is this documented somewhere? > > >> Is it actually used

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Igor Mammedov
On Tue, 3 Jan 2017 17:10:15 +0100 Paolo Bonzini wrote: > > > On 03/01/2017 15:22, Eduardo Habkost wrote: > >> I didn't know that. Is this documented somewhere? > >> Is it actually used by any existing software? > > not that I know of. But users should be fixed if they are not using it. > > > >

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Paolo Bonzini
On 03/01/2017 15:22, Eduardo Habkost wrote: >> I didn't know that. Is this documented somewhere? >> Is it actually used by any existing software? > not that I know of. But users should be fixed if they are not using it. > > I see. The problem is that the mechanism is undocumented, > untested, an

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Igor Mammedov
On Tue, 3 Jan 2017 12:22:23 -0200 Eduardo Habkost wrote: > On Tue, Jan 03, 2017 at 02:02:52PM +0100, Igor Mammedov wrote: > > On Fri, 30 Dec 2016 16:23:08 -0200 > > Eduardo Habkost wrote: > > > > > On Fri, Dec 30, 2016 at 03:28:34PM +0100, Igor Mammedov wrote: > > > > On Thu, 29 Dec 2016 20

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Eduardo Habkost
On Tue, Jan 03, 2017 at 02:02:52PM +0100, Igor Mammedov wrote: > On Fri, 30 Dec 2016 16:23:08 -0200 > Eduardo Habkost wrote: > > > On Fri, Dec 30, 2016 at 03:28:34PM +0100, Igor Mammedov wrote: > > > On Thu, 29 Dec 2016 20:38:15 -0200 > > > Eduardo Habkost wrote: > > > > > > > The "hotplugged

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2017-01-03 Thread Igor Mammedov
On Fri, 30 Dec 2016 16:23:08 -0200 Eduardo Habkost wrote: > On Fri, Dec 30, 2016 at 03:28:34PM +0100, Igor Mammedov wrote: > > On Thu, 29 Dec 2016 20:38:15 -0200 > > Eduardo Habkost wrote: > > > > > The "hotplugged" property is user visible, but it was never meant > > > to be set by the user.

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2016-12-30 Thread Eduardo Habkost
On Fri, Dec 30, 2016 at 03:28:34PM +0100, Igor Mammedov wrote: > On Thu, 29 Dec 2016 20:38:15 -0200 > Eduardo Habkost wrote: > > > The "hotplugged" property is user visible, but it was never meant > > to be set by the user. There are probably multiple ways to break > > or crash device code by ove

Re: [Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2016-12-30 Thread Igor Mammedov
On Thu, 29 Dec 2016 20:38:15 -0200 Eduardo Habkost wrote: > The "hotplugged" property is user visible, but it was never meant > to be set by the user. There are probably multiple ways to break > or crash device code by overriding the property. One example: > > $ qemu-system-x86_64 -cpu qemu64,

[Qemu-devel] [PATCH] qdev: Make "hotplugged" property read-only

2016-12-29 Thread Eduardo Habkost
The "hotplugged" property is user visible, but it was never meant to be set by the user. There are probably multiple ways to break or crash device code by overriding the property. One example: $ qemu-system-x86_64 -cpu qemu64,hotplugged=true Segmentation fault (core dumped) The DeviceState::h